Closed
Bug 1000350
Opened 11 years ago
Closed 11 years ago
don't overwrite a layout set display port base with a APZC-guessed one
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Attachment #8411180 -
Flags: review?(bugmail.mozilla)
Comment 1•11 years ago
|
||
Comment on attachment 8411180 [details] [diff] [review]
patch
Review of attachment 8411180 [details] [diff] [review]:
-----------------------------------------------------------------
Fine by me although I probably would have modified SetDisplayPortBase to take a priority value instead, to keep it parallel to SetDisplayPortMargins and SetDisplayPortForElement.
Attachment #8411180 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 2•11 years ago
|
||
That didn't occur to me. But it seems a little silly to keep a value around that we know is wrong. Also, how do we manage priority levels? AZPC for display port base uses 0, layout uses 1, testing using 2? It would get more confusing then it needs to be I think.
Comment 3•11 years ago
|
||
Yeah that's probably what I would have done (wrt managing priority levels). But it doesn't matter, you can land the patch you have. If we decide later we want something different it's not hard to change.
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•