Open Bug 1003031 Opened 11 years ago Updated 2 years ago

Tour page either isn't calling UITour APIs, or API calls aren't getting allowed to be processed

Categories

(Firefox :: Tours, defect)

29 Branch
defect

Tracking

()

People

(Reporter: Unfocused, Unassigned)

References

Details

Attachments

(1 file)

On upgrading to the 29.0 release, RealRaven is having issues with the tour page. It seems the UITour API calls either aren't getting called, or just aren't working. It was mentioned that the tour was experienced on Aurora already - if this was on the same profile, this could potentially be related to the issue. Still need to debug further, and gather more information.
Transcript from the IRC conversation: 20:19 <RealRaven> Hi guys - anybody up yet ? Just some feedback on the australis update 20:22 <Unfocused> RealRaven: i'm around 20:23 <RealRaven> Great - the experience is not good (but ymmv) : 20:23 <RealRaven> https://www.mozilla.org/en-US/firefox/29.0/whatsnew/?oldversion=28.0 20:23 <RealRaven> this is what I get: Firefox logo and "Committed to you,your privacy and an open Web". no links no other content 20:24 <RealRaven> I would have at least expected a feature tour and a link to one of the many Statusbar Addons (preferably Teo's) ? 20:25 <RealRaven> Or is it Adblock PLus that hides everything? 20:25 <Unfocused> hm, you don't get a doorhanger over the new firefox menu button on the right? like this: http://prntscr.com/3ehosd 20:25 <RealRaven> no, no door hanger. 20:26 <RealRaven> I know I have watched the tour already on Aurora, but it doesn't popup automagically on my Firefox Release version / profile 20:26 <RealRaven> is there an about:config setting that sets it to "watched already"? 20:27 <RealRaven> iirc I can get it via the help menu? 20:27 <Unfocused> no - regardless of whether you've seen it or not, the page should still work 20:27 <Unfocused> yea, you can 20:27 <RealRaven> nope. I do have Adblock Plus and Noscript installed but both have mozilla.org whitelisted 20:27 <Unfocused> is there anything listed in the error console? 20:28 <RealRaven> let me check 20:28 <RealRaven> (reloads page) 20:28 <RealRaven> there are a ton of Content warnings, do you want a pastebin? 20:28 <RealRaven> (using console2 here) 20:29 <RealRaven> http://pastebin.mozilla.org/5001983 20:29 <RealRaven> I can filter out some stuff if I have to? 20:30 <RealRaven> ( I switched off CSS logging already). But I have "report strict warnings" and "Report all JS exceptions" enabled. 20:31 → msucan joined ↔ bbondy popped in 20:33 <Unfocused> RealRaven: can you open about:config, and give me the value of the following prefs: 20:33 <Unfocused> browser.uitour.whitelist.add.260 20:33 <Unfocused> browser.uitour.seenPageIDs 20:34 <Unfocused> browser.uitour.enabled 20:38 <RealRaven> wd 20:38 <RealRaven> they are all default except browser.uitour.whitelist.add.260 which is an empty string 20:39 <RealRaven> there is no seenPageIDs 20:39 <RealRaven> enabled is true 20:39 <Unfocused> hm, ok 20:39 <RealRaven> browser.uitour.enabled = true 20:39 <RealRaven> browser.uitour.url = https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/tour/ 20:40 <RealRaven> browser.uitour.themeOrigin = https://addons.mozilla.org/%LOCALE%/firefox/themes/ 20:41 <RealRaven> Unfocused: can you file a bug? I really have to go to work... 20:42 <Unfocused> RealRaven: yep, can do 20:42 <Unfocused> i'll add a snippet of code to help debug this 20:42 <Unfocused> when you get home 20:45 <RealRaven> cool
So, one possibility is that the www.mozilla.org domain was never given permission to use the UITour APIs. Could you open the Scratchpad (Shift-F4), set it to use the Browser environment (top menu -> Environment -> Browser). For the Environment menu to show, you'll need to have enabled chrome debugging (F12 in a normal tab, devtools settings, "Enable chrome and addon debugging"). And enter the following code: Services.perms.testPermission(makeURI("https://www.mozilla.org/"), "uitour") And then display the result (top menu -> Execute -> Display).
Ok, done that. I usually use Venkman :P Services.perms.testPermission(makeURI("https://www.mozilla.org/"), "uitour"); /* 0 */
Well, that confirms it then - for some reason, that domain was never given permissions to use those APIs. The following should fix this for you: * Open about:config * Reset the browser.uitour.whitelist.add.260 preference * Restart * Try using the tour again
Doorhanger shows up after resetting the about:config setting you mentioned. see screenshot.
If this ends up being a common enough issue that we think requires a hotfix, the following code will fix the permissions issue: Services.perms.add(makeURI("https://www.mozilla.org/"), "uitour", Services.perms.ALLOW_ACTION);
(In reply to Blair McBride [:Unfocused] from comment #6) > If this ends up being a common enough issue that we think requires a hotfix, I should mention, I currently have no reason to think this is anything but an isolated occurrence. But it's nice to have a plan, just in case.
(In reply to Blair McBride [:Unfocused] from comment #7) > (In reply to Blair McBride [:Unfocused] from comment #6) > > If this ends up being a common enough issue that we think requires a hotfix, > > I should mention, I currently have no reason to think this is anything but > an isolated occurrence. But it's nice to have a plan, just in case. Well I was chatting on #Firefox earlier this morning and there were at least 2 other users who had the issue.
Blocks: fx-UITour
Our permissions code has had a weird bug for years where permissions would get lost for some reason. I've seen this happen for the XPI whitelist with getpersonas.com and AMO being dropped. I've never been able to figure out steps to reproduce but I suspect this is the same problem.
Moving open UITour bugs to Firefox::Tours. Filter on firefox-tours-20150121.
Component: General → Tours
(In reply to Matthew N. [:MattN] from comment #9) > Our permissions code has had a weird bug for years where permissions would > get lost for some reason. I've seen this happen for the XPI whitelist with > getpersonas.com and AMO being dropped. I've never been able to figure out > steps to reproduce but I suspect this is the same problem. Good news! I figured it out in bug 1048689 comment 24 and we fixed that issue in Firefox 35! realRaven, can you confirm that you have used the Clear Recent History dialog before the problem with "Site Preferences" checked?
Flags: needinfo?(axelg)
(In reply to Matthew N. [:MattN] from comment #11) > (In reply to Matthew N. [:MattN] from comment #9) > > Our permissions code has had a weird bug for years where permissions would > > get lost for some reason. I've seen this happen for the XPI whitelist with > > getpersonas.com and AMO being dropped. I've never been able to figure out > > steps to reproduce but I suspect this is the same problem. > > Good news! I figured it out in bug 1048689 comment 24 and we fixed that > issue in Firefox 35! > > realRaven, can you confirm that you have used the Clear Recent History > dialog before the problem with "Site Preferences" checked? Sorry it has been such a long time, but I never ever use Clear History as I am too lazy and I am afraid of loosing my form data.
Flags: needinfo?(axelg)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: