Closed
Bug 100310
Opened 23 years ago
Closed 23 years ago
gfx base depends on string bundles
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9.5
People
(Reporter: alecf, Assigned: alecf)
References
Details
(Whiteboard: fix in hand)
Attachments
(1 file)
|
(deleted),
patch
|
jag+mozilla
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
in mozilla/gfx/src/nsDeviceContext.cpp, we have two routines, GetLocalizedBundle
and GetLocalizedString, which are only used on windows. This creates an
unnecessary dependency on other platforms.
I've moved these two routines into gfx/src/windows. Patch forthcoming.
CC'ing pavlov for r=, blizzard for sr=
|
Assignee | |
Updated•23 years ago
|
|
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Comment 2•23 years ago
|
||
the previous patch also splits gfx into gfx and gfxwin - it has no effect on the
dlls that are created (there are two) but cleans up my dependency graphs, making
it clearer where the resulting dependencies are.
reviews?
|
||
Comment 3•23 years ago
|
||
Comment on attachment 49759 [details] [diff] [review]
move string bundles into gfxwin, rename module
r/sr=blizzard
Attachment #49759 -
Flags: superreview+
|
||
Comment 4•23 years ago
|
||
Comment on attachment 49759 [details] [diff] [review]
move string bundles into gfxwin, rename module
Fix the makefile.win changes (missing \, add $(NULL)) and r=jag
Attachment #49759 -
Flags: review+
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: fix in hand
|
|
Assignee | |
Comment 5•23 years ago
|
||
fix is in!
thanks folks
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•