Closed Bug 1007283 Opened 11 years ago Closed 2 years ago

Investigate why animated panels don't work on Linux and re-enable them

Categories

(Core :: Widget: Gtk, defect, P3)

Product:
Core
Component:
Widget: Gtk
Platform:
All
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1007283 - Enable arrow panel animations on Linux.
(deleted), text/x-review-board-request
jaws
: review+
Details
No description provided.
Flags: firefox-backlog?
Depends on: 1001234
Flags: firefox-backlog? → firefox-backlog+
Depends on: 1015166
This is a note that bug 994562 contains more info about the problems with enabling the animation.
Is there information in bug 994562 that is still helpful after bug 1015166 was fixed?
I'd like to try enabling arrow panel animations on Linux to see if window managers out there still can't handle them three years later. FWIW, there's no problem on recent Ubuntu as far as I can tell.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Blocks: photon-animation
Whiteboard: [photon-animation][triage]
Priority: -- → P1
QA Contact: jwilliams
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Comment on attachment 8888056 [details] Bug 1007283 - Enable arrow panel animations on Linux. https://reviewboard.mozilla.org/r/158944/#review166418 I was trying to delay r+'ing this so that bug 1380065 could land first but I don't think it would be polite to wait much longer. We can deal with any of the test failures that pop up on Linux as a result of this. Or if you would like, please delay landing this until bug 1380065 lands.
Attachment #8888056 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6) > Comment on attachment 8888056 [details] > Bug 1007283 - Enable arrow panel animations on Linux. > > https://reviewboard.mozilla.org/r/158944/#review166418 > > I was trying to delay r+'ing this so that bug 1380065 could land first but I > don't think it would be polite to wait much longer. We can deal with any of > the test failures that pop up on Linux as a result of this. Or if you would > like, please delay landing this until bug 1380065 lands. I'd like to land this now to have it in 56, so that if we should run into problems with window managers, we have enough time to re-disable this on Linux for 57.
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e1a1565e417 Enable arrow panel animations on Linux. r=jaws
https://hg.mozilla.org/mozilla-central/rev/4e1a1565e417
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Iteration: --- → 56.4 - Aug 1
Depends on: 1385079
Backed out in https://hg.mozilla.org/mozilla-central/rev/e91b2c85aacd9aa32fbb3a71a7fae14fc21127b2
Status: RESOLVED → REOPENED
status-firefox56: fixed → affected
Resolution: FIXED → ---
Target Milestone: mozilla56 → ---
Iteration: 56.4 - Aug 1 → ---
Flags: firefox-backlog+
Assignee: dao+bmo → nobody
Flags: needinfo?(dao+bmo)
Priority: P1 → P3
Status: REOPENED → NEW
Flags: qe-verify+
(In reply to Wes Kocher (:KWierso) from comment #10) > Backed out in > https://hg.mozilla.org/mozilla-central/rev/ > e91b2c85aacd9aa32fbb3a71a7fae14fc21127b2 For the record, the set of affected window managers includes FVWM. (I was trying to figure out why the fix for getUserMedia in bug 1384986 seemed to have stopped working. I was not expecting *this*.)
Flags: qe-verify+
Priority: P3 → --
QA Contact: jwilliams
Whiteboard: [reserve-photon-animation]
Given that we know panels have a number of annoying quirks and are regression-prone, I'd like to defer any further work here until after 57. (In fact, I'm pushing to prioritize some post-57 time for fixing the pains in panels, so we don't keep running into problems with them.)
Hey guys, any news on re-enabling animated panels on Linux?
(In reply to Danilo from comment #13) > Hey guys, any news on re-enabling animated panels on Linux? We're going to need a lower level way of detecting window manager and compositor capability. "Linux" isn't really a meaningful descriptor in this context - it only tells us it might not work. AFAIK the landscape hasn't changed here, Dao may know more. Is there a bug filed which tracks this?
Flags: needinfo?(dao+bmo)
(In reply to Sam Foster [:sfoster] from comment #14) > (In reply to Danilo from comment #13) > > Hey guys, any news on re-enabling animated panels on Linux? > > We're going to need a lower level way of detecting window manager and > compositor capability. "Linux" isn't really a meaningful descriptor in this > context - it only tells us it might not work. AFAIK the landscape hasn't > changed here, Dao may know more. Is there a bug filed which tracks this? No, just this bug. We'll need some Widget: Gtk work if we want to enable this on a per-WM basis. Could be done in this bug or a new one.
Flags: needinfo?(dao+bmo)
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL

Martin, do you think this might be worth trying again?

FYI, there's now a hidden pref for this: xul.panel-animations.enabled

Severity: normal → --
status-firefox56: affected → ---
Component: XUL → Widget: Gtk
Depends on: 1546542
Flags: needinfo?(stransky)

I tested latest nightly with proton on Gnome/Fedora 34 and it looks Ok to me. We can enable the animations for known working WM only, we do so for hidden system titlebar too, see:

https://searchfox.org/mozilla-central/rev/083983b7f09b00cdfe4f70396e39ea4f8a1735e1/widget/gtk/nsWindow.cpp#8330

Flags: needinfo?(stransky)
Priority: -- → P3

This works for everything but KDE (bug 1813070).

Status: NEW → RESOLVED
Closed: 7 years ago → 2 years ago
Resolution: --- → FIXED
Assignee: nobody → dao+bmo
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: