STR 1. Make an emergency call on CDMA network 2. End the emergency call Expected: Emergency callback mode icon should show in the status bar indicating that the phone is in ECM. Observed: No status bar icon for ECM is displayed.

The bug 946548 broke the feature as http://lxr.mozilla.org/gaia/source/apps/system/js/emergency_callback_manager.js#194 expects the network type to be CDMA when networkType is no longer the currently active network by the network type setting, such as CDMA/Evdo Auto, CDMA only and so on. We need a change like that's done as part of https://github.com/mozilla-b2g/gaia/pull/17368/files call.js and use mozMobileConnection.voice.type instead of getPreferredNetwork as is currently being used in emergency_callback_manager.js. Another issue that needs to be addressed is that emergency_callback_manager.js assumes that on bootup the network would be CDMA while for a global phone the network type at the start could be GSM and later switched to CDMA. There are two solutions I can think of. 1. Add a voice network change listener to init emergency_callback_manager.js when the network type changed to CDMA. 2. Always initialize emergency_callback_manager.js irrespective of the network as ECM mode change will only get triggered for CDMA. Solution #2 will also fix the original problem reported in this bug.

Preeti, could you please get someone to look at this issue.

David, Can you please have someone take a look, given the dialer component?

There's no CDMA network in Europe, so I guess we'll also need someone to support testing when patch is done.

Wesley, I can test the patch.

Hi Omega, Do we have the emergency callback mode in CDMA defined?

Wesley Who are you suggesting should provide a patch here?

I found the UX document (https://bug890825.bugzilla.mozilla.org/attachment.cgi?id=791120) and the feature was done in Bug 881863 by Steve. NI? Tim as Steve is on PTO. Correct component should be GAIA:System instead of Dialer.

Wesley, you are right, the feature was implemented in bug 881863. Jose, according to Anshul in comment 1 your patch broke this feature. Would you be able to fix this before 5/15 according to partner schedule?

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #9) > Wesley, you are right, the feature was implemented in bug 881863. > > Jose, according to Anshul in comment 1 your patch broke this feature. Would > you be able to fix this before 5/15 according to partner schedule? Sadly I don't have time to address the issues here. Arthur might have and he could test the fix. Sorry.

Arthur, please reassign this bug or take it.

Just discuss with Arthur and I can help with based on Anshul's suggestion in comment 2. I'll also add some adjustment for multisim scenario(although we don't have dsds CDMA device for now).

Hi Alive, I removed the connection checking and add EmergencyCbModeChange event listener in this patch because it won't affact other non-CDMA connection behavior, please feel free to leave feedback if you have any question about the patch, thanks.

BTW since we didn't have the CDMA DSDS device before, current codebase didn't handle for DSDS scenario. I'll create another bug to address CDMA DSDS issue because it will need more discussion and UX input.

Comment on attachment 8421586 [details] Link to github r+ with nits, please make sure test passes. thanks!

(In reply to Wesley Huang [:wesley_huang] from comment #8) > I found the UX document > (https://bug890825.bugzilla.mozilla.org/attachment.cgi?id=791120) and the > feature was done in Bug 881863 by Steve. NI? Tim as Steve is on PTO. > Correct component should be GAIA:System instead of Dialer. Wesley, as per the UX spec you mentioned, the browser app, SMS and dialer are supposed to show a ECM pop up asking user to exit the ECM when for example a call is being made. I don't see that happening nor any code is any of these apps doing the same. Should I file a new bug for the same?

(In reply to Anshul from comment #16) > (In reply to Wesley Huang [:wesley_huang] from comment #8) > > I found the UX document > > (https://bug890825.bugzilla.mozilla.org/attachment.cgi?id=791120) and the > > feature was done in Bug 881863 by Steve. NI? Tim as Steve is on PTO. > > Correct component should be GAIA:System instead of Dialer. > Wesley, as per the UX spec you mentioned, the browser app, SMS and dialer > are supposed to show a ECM pop up asking user to exit the ECM when for > example a call is being made. I don't see that happening nor any code is any > of these apps doing the same. Should I file a new bug for the same? ni? Eric for visibility from QA. Yes. I think so, if the ni? Eric for visibility from QA.

We should if the ECM dialog never pops up. That's a separate bug.

(In reply to Anshul from comment #16) > (In reply to Wesley Huang [:wesley_huang] from comment #8) > > I found the UX document > > (https://bug890825.bugzilla.mozilla.org/attachment.cgi?id=791120) and the > > feature was done in Bug 881863 by Steve. NI? Tim as Steve is on PTO. > > Correct component should be GAIA:System instead of Dialer. > Wesley, as per the UX spec you mentioned, the browser app, SMS and dialer > are supposed to show a ECM pop up asking user to exit the ECM when for > example a call is being made. I don't see that happening nor any code is any > of these apps doing the same. Should I file a new bug for the same? Theoretically, the dialog should popup because we register a callback for connection dataerror[1]. Anshul, did you discovery any console error from the log? Thanks. [1]https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/emergency_callback_manager.js#L160

Nits applied and Travis is green. in master: e927a832658cf21d3c62efc6359e49d347c4d358

Comment on attachment 8421586 [details] Link to github NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 946548 [User impact] if declined: Unable to display Emergency callback mode notice and prompt. [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: N/A

Comment on attachment 8421586 [details] Link to github Taking for 1.4

The blocking flag was incorrectly set here - fixing the flag.

Test cases here http://mzl.la/1mU8szb I am trying to build master and v1.4 now, will update soon.

(In reply to Steve Chung [:steveck] from comment #20) > Nits applied and Travis is green. > in master: e927a832658cf21d3c62efc6359e49d347c4d358 Please resolve the bug when landing on master.

v1.4: https://github.com/mozilla-b2g/gaia/commit/6ca3466e92eb99b8ccc3668261be8cf033505cad

(In reply to Steve Chung [:steveck] from comment #19) > (In reply to Anshul from comment #16) > > (In reply to Wesley Huang [:wesley_huang] from comment #8) > > > I found the UX document > > > (https://bug890825.bugzilla.mozilla.org/attachment.cgi?id=791120) and the > > > feature was done in Bug 881863 by Steve. NI? Tim as Steve is on PTO. > > > Correct component should be GAIA:System instead of Dialer. > > Wesley, as per the UX spec you mentioned, the browser app, SMS and dialer > > are supposed to show a ECM pop up asking user to exit the ECM when for > > example a call is being made. I don't see that happening nor any code is any > > of these apps doing the same. Should I file a new bug for the same? > > Theoretically, the dialog should popup because we register a callback for > connection dataerror[1]. Anshul, did you discovery any console error from > the log? Thanks. > > [1]https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/ > emergency_callback_manager.js#L160 Steve, what about SMS and dialer; how would they display the error?

(In reply to Anshul from comment #5) > Wesley, I can test the patch. Hi, Anshul, Could you also try that, I am still building it and will try to verify that asap, thank you.

(In reply to Eric Chang [:ericcc] [:echang] from comment #28) > (In reply to Anshul from comment #5) > > Wesley, I can test the patch. > Hi, Anshul, Could you also try that, I am still building it and will try to > verify that asap, thank you. The patch is working fine. I am now able to see the ECM UI as expected.

(In reply to Anshul from comment #29) > (In reply to Eric Chang [:ericcc] [:echang] from comment #28) > > (In reply to Anshul from comment #5) > > > Wesley, I can test the patch. > > Hi, Anshul, Could you also try that, I am still building it and will try to > > verify that asap, thank you. > The patch is working fine. I am now able to see the ECM UI as expected. Just found that, the current wasabi phone doesn't send the ENTER_ECM event out. And I checked with local CDMA operator in Taiwan, they don't this either. But glad to know that patch is working from Anshul's testing, thanks a lot. https://bugzilla.mozilla.org/show_bug.cgi?id=881863#c26

Hi Anshul, sorry I could not verify this behavior because local CDMA provider doesn't have the ECM. We just mock modem's behavior that "assume" modem will block network access and return a error callback by themselves. Could you please help verify: 1) The network access(dialer/sms/browser) is actually blocked after entering the ECM 2) The dialog is popup up while acceesing the network in ECM. And please fire a bug if any of them failed, thanks!

(In reply to Steve Chung [:steveck] from comment #31) > Hi Anshul, sorry I could not verify this behavior because local CDMA > provider doesn't have the ECM. We just mock modem's behavior that "assume" > modem will block network access and return a error callback by themselves. > Could you please help verify: > > 1) The network access(dialer/sms/browser) is actually blocked after entering > the ECM I am checking the behavior by I don't see from the code how Gaia will end up displaying the ECM mode error when user tries to dial a call in ECM mode as per https://bug890825.bugzilla.mozilla.org/attachment.cgi?id=791120. > 2) The dialog is popup up while acceesing the network in ECM. > > And please fire a bug if any of them failed, thanks!

This is covered by https://moztrap.mozilla.org/manage/case/9418/