Closed
Bug 1008225
Opened 11 years ago
Closed 8 years ago
Remove fog / frost effect behind the menu bar on Windows 8
Categories
(Firefox :: Theme, defect, P4)
Tracking
()
VERIFIED
FIXED
Firefox 51
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [outreachy-12])
Attachments
(1 file)
(deleted),
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
From bug 1007229:
That fog was intended for aero glass. It made sense to keep it on Windows 8 as long as we couldn't adjust the text color depending on the frame color, but now not so much. It feels super alien on Windows 8.
Assignee | ||
Updated•11 years ago
|
Flags: firefox-backlog+
Assignee | ||
Updated•10 years ago
|
Whiteboard: p=3 [qa+]
Updated•10 years ago
|
Points: --- → 3
Flags: qe-verify+
Whiteboard: p=3 [qa+]
Updated•9 years ago
|
Priority: -- → P4
Updated•9 years ago
|
Comment 3•9 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Was this fixed by bug 1184651?
Nah, there's still a lighter frostness behind the menu bar on its own on win8. It's gone in win10, but not win8.
Updated•9 years ago
|
Flags: needinfo?(dao)
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> > Was this fixed by bug 1184651?
>
> Nah, there's still a lighter frostness behind the menu bar on its own on
> win8. It's gone in win10, but not win8.
But then bug 1235320 isn't a duplicate :/
No longer blocks: 1248735
Updated•9 years ago
|
Assignee: dao → nobody
Mentor: jaws
Status: ASSIGNED → NEW
Whiteboard: [outreachy-12]
Assignee | ||
Comment 5•9 years ago
|
||
Jared, you have a plan for how to approach this? You're sure this is a good candidate for a mentored bug?
Flags: needinfo?(jaws)
Comment 6•9 years ago
|
||
I was planning to make this one of the penultimate bugs of the Outreach internship, but hesitated on changing the Points column since you had already put in "3" and I assumed you knew of a clear path forward based on that score. I was ready to put an 8 or 13 on it.
I was hoping that by the end of the internship, the intern will have enough experience to be willing to investigate what is necessary and not need as much hand-holding.
Flags: needinfo?(jaws)
Updated•9 years ago
|
Points: 3 → 8
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Mentor: jaws
Comment 8•8 years ago
|
||
Comment on attachment 8778561 [details] [diff] [review]
move Aero Glass-specific rules from -moz-windows-compositor section to -moz-windows-glass section
Review of attachment 8778561 [details] [diff] [review]:
-----------------------------------------------------------------
Looks reasonable. I don't have access to test machines with the various versions of Windows, so my r+ here is more a sanity check by code inspection than a full review. That's probably enough though :).
Attachment #8778561 -
Flags: review?(florian) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1727a7c7f2f
move Aero Glass-specific rules from -moz-windows-compositor section to -moz-windows-glass section. r=florian
Comment 10•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment 11•8 years ago
|
||
I have reproduced this bug with Nightly 32.0a1 (2014-05-09) on Windows 8.1 , 64 bit!
This Bug's fix is verified on Latest Nightly 51.0a1.
Build ID : 20160810030202
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
[bugday-20160810]
Assignee | ||
Comment 12•8 years ago
|
||
(In reply to azmina721 from comment #11)
> I have reproduced this bug with Nightly 32.0a1 (2014-05-09) on Windows 8.1 ,
> 64 bit!
> This Bug's fix is verified on Latest Nightly 51.0a1.
>
> Build ID : 20160810030202
> User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101
> Firefox/51.0
>
> [bugday-20160810]
Thanks!
Status: RESOLVED → VERIFIED
Comment 13•8 years ago
|
||
Assignee | ||
Comment 14•8 years ago
|
||
status-firefox50:
--- → fixed
Comment 15•8 years ago
|
||
Verified fixed on Windows 8.1 x64 using latest DevEdition 50.0a2, build ID 20160914004005.
You need to log in
before you can comment on or make changes to this bug.
Description
•