Closed
Bug 100967
Opened 23 years ago
Closed 23 years ago
[FIX]no "fit to page" option when printing, printing large pages results in cropping
Categories
(Core :: Printing: Output, defect)
Core
Printing: Output
Tracking
()
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: Bill.Burns, Assigned: rods)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dcone
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
i received a large jpg file as an attachment in email. I double-clicked the
attachment to open it in a new browser window.
When I tried to print the image which was about 2x2 pages large, Netscape6 only
printed the first page. It didn't try to scale the image to fit on one page NOR
did it print the other pages that make up the total image.
RFE: The "fit to 1 page" option is missing (compared to Netscape 4.x)
BUG: When an image (or html page) is larger than one piece of paper, the browser
needs to print everything instead of cropping.
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 1•23 years ago
|
||
Kevin, was this one of the PRD items? It seems familar?
Assignee: dcone → rods
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Comment 2•23 years ago
|
||
I think this could be part of the PRD item to force output to specified number
of pages.
Assignee | ||
Updated•23 years ago
|
Target Milestone: --- → Future
Depends on: 106332
*** Bug 113398 has been marked as a duplicate of this bug. ***
The bug part of this is fixed by bug 110529 - don't have perms to change the
Summary.
Comment 6•23 years ago
|
||
Moving to Moz1.0. Rod will analyze how difficult it will be to implement this.
Target Milestone: Future → mozilla1.0
*** Bug 116553 has been marked as a duplicate of this bug. ***
This would be nice to have on all platforms not only Windows2000
OS: Windows 2000 → All
Hardware: PC → All
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla1.0 → mozilla0.9.9
Assignee | ||
Comment 10•23 years ago
|
||
1) In DocumentViewer: I did rearrange some of the data members for PrintData
and PrintObject and their initialization order
2) In DocumentViewer: Implemented the shrink to fit feature by calc'ing the
ratios in the first reflow and then reflowing a second time to shrink them
3) In nsPageFrame: This is somewhat unrelated to this bug, but I found where
continuing frame content was being parented to the PageFrame instead of the
PageContentFrame.
4) Although at this time I am not using DumpFrames for debugging I may want to
switch back to it while debugging at anytime.
Assignee | ||
Updated•23 years ago
|
Summary: no "fit to page" option when printing, printing large pages results in cropping → [FIX]no "fit to page" option when printing, printing large pages results in cropping
Comment 11•23 years ago
|
||
Comment on attachment 69664 [details] [diff] [review]
patch
I would prefer something besides XMost.. I dont know what that means. r=dcone.
Attachment #69664 -
Flags: review+
Comment 12•23 years ago
|
||
Comment on attachment 69664 [details] [diff] [review]
patch
Why did you reimplement RootFrameList? Can't you just call the static on on
nsIFrameDebug?
In the code where you are doing he shrinking, you are assuming that there will
be an HTML frame (asserted) - what about XML? Did you test this with XML (looks
like it will work, but the assertion/comment is wrong)?
When looking for the XMost frame, don't you need to check for whether or not it
is visible? If you had a hidden frame that was way off to the right it would
skew the scaling factor I think.
What is FindXMostPO() and why is it needed?
Assignee | ||
Comment 13•23 years ago
|
||
Good catch on the visibility, I created a new testcase, and you were right, so
I added the vis code and now it prints correctly.
I couldn't use nsIFrameDebug::RootFrameList because DocViewer is in content and
it fails on link, so only layout classes can use it.
It does print XML so I changed the comment.
The meaning of FindXMostPO() is briefly explained where it is defined, it finds
the widest or XMost PrintObject that contains the XMost or widest layout frame.
Attachment #69664 -
Attachment is obsolete: true
Comment 14•23 years ago
|
||
Comment on attachment 69698 [details] [diff] [review]
new patch (checks for visibility)
I would prefer MaxXWidth of XMost but not a big deal. r=dcone
Attachment #69698 -
Flags: review+
Comment 15•23 years ago
|
||
Comment on attachment 69698 [details] [diff] [review]
new patch (checks for visibility)
sr=attinasi - thanks Rod
Attachment #69698 -
Flags: superreview+
Assignee | ||
Comment 16•23 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 17•23 years ago
|
||
there is a new "Shrink to fit page width" option in Page Setup.
Thus this bug has been addressed.
REOPEN if you disagree..
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•