Closed Bug 1009855 Opened 11 years ago Closed 10 years ago

Improve workflow for specifying custom flags to the build in marionette-js tests...

Categories

(Testing Graveyard :: JSMarionette, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jlal, Unassigned)

References

Details

Attachments

(2 files)

So we can test all our feature flags in the tests we need a nicer workflow maybe like this: ```js var client = marionette.client({ env: { MAGIC_CONFIG_FLAG: '1' } }) ```
We have tests written for the new rocketbar functionality (2.1), however this is starting to conflict with the behaviour in master, all the code is landed in master and is currently behind a HAIDA=1 build flag, the example code would be perfect
Tried looking at the flow between marionette / mozilla-profile build but having trouble understanding where / how it interacts with the rest of the gaia build system, if I could get any pointers would like to work on this, starting to block me a bit. Cheers
Flags: needinfo?(jlal)
Hey gareth, you have any idea on this front?
Flags: needinfo?(jlal) → needinfo?(gaye)
Hey Dale, I think this is what you're looking for. Try it out and let me know!
Attachment #8458931 - Flags: review?(jlal)
Attachment #8458931 - Flags: review?(dale)
Flags: needinfo?(gaye)
Blocks: 1041235
Thanks a lot Gareth, annoyed at myself for not looking deeper, I was checking the wrong repo, testing now
Attached patch browser.patch (deleted) — Splinter Review
A brief test of this isnt working for me, with this patch when I run TEST_FILES=apps/system/test/marionette/rocketbar_test.js make test-integration-test I see the browser being opened, this shouldnt happen as with HAIDA the browser activities are deleted, if I manually install HAIDA=1 make reset-gaia and enter a url, it does not open the browser app, will investigate more
Comment on attachment 8458931 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21947 Given the short time between running tests, I dont think this is doing the original proposal which is to use the flags as part of building the profile. Kevin had other ideas which would require less infrastructure, and its looking like we need this less as the build flag is due to be removed, so I dont mind if this gets closed, either way cancelling review. Cheers Gareth, sorry for the distraction
Attachment #8458931 - Flags: review?(dale)
We no longer need this
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Comment on attachment 8458931 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21947 Lets keep this running fast until we make this easier and fast.
Attachment #8458931 - Flags: review?(jlal) → review-
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: