Closed
Bug 1009855
Opened 11 years ago
Closed 10 years ago
Improve workflow for specifying custom flags to the build in marionette-js tests...
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jlal, Unassigned)
References
Details
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
jlal
:
review-
|
Details |
(deleted),
patch
|
Details | Diff | Splinter Review |
So we can test all our feature flags in the tests we need a nicer workflow maybe like this:
```js
var client = marionette.client({
env: { MAGIC_CONFIG_FLAG: '1' }
})
```
Comment 1•11 years ago
|
||
We have tests written for the new rocketbar functionality (2.1), however this is starting to conflict with the behaviour in master, all the code is landed in master and is currently behind a HAIDA=1 build flag, the example code would be perfect
Comment 2•10 years ago
|
||
Tried looking at the flow between marionette / mozilla-profile build but having trouble understanding where / how it interacts with the rest of the gaia build system, if I could get any pointers would like to work on this, starting to block me a bit. Cheers
Flags: needinfo?(jlal)
Comment 3•10 years ago
|
||
Hey gareth, you have any idea on this front?
Flags: needinfo?(jlal) → needinfo?(gaye)
Comment 4•10 years ago
|
||
Hey Dale,
I think this is what you're looking for. Try it out and let me know!
Attachment #8458931 -
Flags: review?(jlal)
Attachment #8458931 -
Flags: review?(dale)
Flags: needinfo?(gaye)
Comment 5•10 years ago
|
||
Thanks a lot Gareth, annoyed at myself for not looking deeper, I was checking the wrong repo, testing now
Updated•10 years ago
|
Blocks: rocketbar-dogfood
Comment 6•10 years ago
|
||
A brief test of this isnt working for me, with this patch when I run
TEST_FILES=apps/system/test/marionette/rocketbar_test.js make test-integration-test
I see the browser being opened, this shouldnt happen as with HAIDA the browser activities are deleted, if I manually install HAIDA=1 make reset-gaia and enter a url, it does not open the browser app, will investigate more
Comment 7•10 years ago
|
||
Comment on attachment 8458931 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21947
Given the short time between running tests, I dont think this is doing the original proposal which is to use the flags as part of building the profile.
Kevin had other ideas which would require less infrastructure, and its looking like we need this less as the build flag is due to be removed, so I dont mind if this gets closed, either way cancelling review.
Cheers Gareth, sorry for the distraction
Attachment #8458931 -
Flags: review?(dale)
Comment 8•10 years ago
|
||
We no longer need this
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8458931 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21947
Lets keep this running fast until we make this easier and fast.
Attachment #8458931 -
Flags: review?(jlal) → review-
Comment 10•10 years ago
|
||
This bug is still mentioned in http://mxr.mozilla.org/gaia/source/apps/system/test/marionette/rocketbar_test.js#43
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•