Closed Bug 1011710 Opened 10 years ago Closed 10 years ago

[Flame][Lockscreen] - Fuzzy images

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pivanov, Unassigned)

References

Details

Attachments

(7 files, 2 obsolete files)

Attached image fuzzy_playback_controls.png (deleted) —
      No description provided.
Hey Patryk, 

the icons "<", "play", "pause", ">" are old ... can I use the same icons from Music App or I need to ping someone for the new icons?
Flags: needinfo?(padamczyk)
Przemek can you please provide Pavel with the latest.
Flags: needinfo?(padamczyk) → needinfo?(pabratowski)
Is this for 1.4 or 2.0?
Amy is re-working the lockscreen for 2.0 right?
Flags: needinfo?(amlee)
(In reply to Przemek Abratowski [:przemek] UX from comment #3)
> Is this for 1.4 or 2.0?
> Amy is re-working the lockscreen for 2.0 right?

Hi Przemek, 

The lockscreen is for 2.0. We are still using the same icons for the music player though.
Flags: needinfo?(amlee)
I just talked to Amy, she will provide the media controls.
Flags: needinfo?(pabratowski) → needinfo?(amlee)
Attached file Music_Player_Controls.zip (obsolete) (deleted) —
Hi Pavel, 

Here are the music player controls. I am wondering if the reason they are fuzzy is because they have been resized incorrectly. The flame is suppose to use @1.5 scaled graphics but the current screenshot shows the icons at a size that is somewhere in between @1.5 and @2 scale. I've attached the @1.5 scaled graphics (these are a bit smaller than the current screenshot).
Flags: needinfo?(amlee)
Thanks Amy :)
actually the @1.5 icons missing from system/media_playback I will create a patch soon for them
Hey Amy ... I just realize that we use bigger icons for the lockscreen ... you can see Bug 891024 ... can you provide me the bigger icons in all variation @1, @1.5 etc. and I will update them too.

P.S. for the normal icons I use the icons from Music App because current icons are old (with shadow)
Flags: needinfo?(amlee)
Attached file music_player_icons.zip (obsolete) (deleted) —
Hi Pavel, 

Okay that makes more sense now. I was wondering why in the screencap the icons were bigger than what we have in the icon sheets. I've attached the icons in the larger size based on bug 891024 @1, @1.5, @2. Let me know if you need anything else! p.s what version are we releasing this for? There is also a visual refresh of the lockscreen for 2.0 that also has the music player in it, Bug 950884. Just want to make sure we use the larger icons in there as well.
Attachment #8425605 - Attachment is obsolete: true
Flags: needinfo?(amlee)
Attached file Big Music Player Icons.zip (deleted) —
Here are the big version of the music player icons for lockscreen. Let me know if you need anything else!
Attachment #8427153 - Attachment is obsolete: true
Attached file patch for Gaia/master (deleted) —
Hey guys,
who can help me to test this on real device?
Attachment #8427994 - Flags: ui-review?(amlee)
Attachment #8427994 - Flags: feedback?(padamczyk)
Attached image 2014-05-21-15-36-20.png (deleted) —
Hi Pavel, 

This is what I'm seeing on the Flame after flashing the patch.
Attached image 2014-05-21-15-36-10.png (deleted) —
Screenshot 2
looks good, right?
Flags: needinfo?(amlee)
Attached image 2014-05-24-09-09-32.png (deleted) —
Flags: needinfo?(amlee)
Hi Pavel, 

I compared my screen (see comment 15) to the original one you attached and the icons look the same.
Flags: needinfo?(pivanov)
Hey Amy, 
as we talk on IRC ... I find the problem and now is OK I think (you can try to flash your device again but don't forget to get latest of my patch). I also find that we miss few more variation of the icons:
we need @2x.png & @2.25x.png versions for:	
icon-next	
icon-pause	
icon-play	
icon-previous
Flags: needinfo?(pivanov)
Comment on attachment 8427994 [details]
patch for Gaia/master

Hi Pavel, 

The icons looks sharp now. Thanks!
Attachment #8427994 - Flags: ui-review?(amlee) → ui-review+
Attached file Big_Music_Controls@2.25.zip (deleted) —
Hi Pavel, 

Here are the controls. Cheers
Attachment #8427994 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8427994 [details]
patch for Gaia/master

Amy will review this.
Attachment #8427994 - Flags: feedback?(padamczyk)
Comment on attachment 8427994 [details]
patch for Gaia/master

rs=me
Attachment #8427994 - Flags: review?(squibblyflabbetydoo) → review+
Thanks all,

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/29a19e61a3b5fae7d257fdc0a56fbad2055576dc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: