Closed
Bug 1011710
Opened 10 years ago
Closed 10 years ago
[Flame][Lockscreen] - Fuzzy images
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pivanov, Unassigned)
References
Details
Attachments
(7 files, 2 obsolete files)
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Hey Patryk, the icons "<", "play", "pause", ">" are old ... can I use the same icons from Music App or I need to ping someone for the new icons?
Flags: needinfo?(padamczyk)
Comment 2•10 years ago
|
||
Przemek can you please provide Pavel with the latest.
Flags: needinfo?(padamczyk) → needinfo?(pabratowski)
Comment 3•10 years ago
|
||
Is this for 1.4 or 2.0? Amy is re-working the lockscreen for 2.0 right?
Flags: needinfo?(amlee)
Comment 4•10 years ago
|
||
(In reply to Przemek Abratowski [:przemek] UX from comment #3) > Is this for 1.4 or 2.0? > Amy is re-working the lockscreen for 2.0 right? Hi Przemek, The lockscreen is for 2.0. We are still using the same icons for the music player though.
Flags: needinfo?(amlee)
Comment 5•10 years ago
|
||
I just talked to Amy, she will provide the media controls.
Flags: needinfo?(pabratowski) → needinfo?(amlee)
Comment 6•10 years ago
|
||
Hi Pavel, Here are the music player controls. I am wondering if the reason they are fuzzy is because they have been resized incorrectly. The flame is suppose to use @1.5 scaled graphics but the current screenshot shows the icons at a size that is somewhere in between @1.5 and @2 scale. I've attached the @1.5 scaled graphics (these are a bit smaller than the current screenshot).
Flags: needinfo?(amlee)
Reporter | ||
Comment 7•10 years ago
|
||
Thanks Amy :) actually the @1.5 icons missing from system/media_playback I will create a patch soon for them
Reporter | ||
Comment 8•10 years ago
|
||
Hey Amy ... I just realize that we use bigger icons for the lockscreen ... you can see Bug 891024 ... can you provide me the bigger icons in all variation @1, @1.5 etc. and I will update them too. P.S. for the normal icons I use the icons from Music App because current icons are old (with shadow)
Flags: needinfo?(amlee)
Comment 9•10 years ago
|
||
Hi Pavel, Okay that makes more sense now. I was wondering why in the screencap the icons were bigger than what we have in the icon sheets. I've attached the icons in the larger size based on bug 891024 @1, @1.5, @2. Let me know if you need anything else! p.s what version are we releasing this for? There is also a visual refresh of the lockscreen for 2.0 that also has the music player in it, Bug 950884. Just want to make sure we use the larger icons in there as well.
Attachment #8425605 -
Attachment is obsolete: true
Flags: needinfo?(amlee)
Comment 10•10 years ago
|
||
Here are the big version of the music player icons for lockscreen. Let me know if you need anything else!
Attachment #8427153 -
Attachment is obsolete: true
Reporter | ||
Comment 11•10 years ago
|
||
Hey guys, who can help me to test this on real device?
Attachment #8427994 -
Flags: ui-review?(amlee)
Attachment #8427994 -
Flags: feedback?(padamczyk)
Comment 12•10 years ago
|
||
Hi Pavel, This is what I'm seeing on the Flame after flashing the patch.
Comment 13•10 years ago
|
||
Screenshot 2
Comment 15•10 years ago
|
||
Flags: needinfo?(amlee)
Comment 16•10 years ago
|
||
Hi Pavel, I compared my screen (see comment 15) to the original one you attached and the icons look the same.
Flags: needinfo?(pivanov)
Reporter | ||
Comment 17•10 years ago
|
||
Hey Amy, as we talk on IRC ... I find the problem and now is OK I think (you can try to flash your device again but don't forget to get latest of my patch). I also find that we miss few more variation of the icons: we need @2x.png & @2.25x.png versions for: icon-next icon-pause icon-play icon-previous
Flags: needinfo?(pivanov)
Comment 18•10 years ago
|
||
Comment on attachment 8427994 [details]
patch for Gaia/master
Hi Pavel,
The icons looks sharp now. Thanks!
Attachment #8427994 -
Flags: ui-review?(amlee) → ui-review+
Comment 19•10 years ago
|
||
Hi Pavel, Here are the controls. Cheers
Reporter | ||
Updated•10 years ago
|
Attachment #8427994 -
Flags: review?(squibblyflabbetydoo)
Comment 20•10 years ago
|
||
Comment on attachment 8427994 [details]
patch for Gaia/master
Amy will review this.
Attachment #8427994 -
Flags: feedback?(padamczyk)
Comment 21•10 years ago
|
||
Comment on attachment 8427994 [details]
patch for Gaia/master
rs=me
Attachment #8427994 -
Flags: review?(squibblyflabbetydoo) → review+
Reporter | ||
Comment 22•10 years ago
|
||
Thanks all, Landed to master: https://github.com/mozilla-b2g/gaia/commit/29a19e61a3b5fae7d257fdc0a56fbad2055576dc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•