jonsmirl found a really ugly use of necko just to create a string bundle. I've found another one with LXR: http://lxr.mozilla.org/seamonkey/search?string=apropfilename the two bad uses are in htmlparser and in nsFormControlHelper. I'll attach patches shortly.

cc'ing attinasi (Layout), harishd (parser) and rods (HTML Form controls) for reviews. This stuff is pretty straight forward....can I get an r= and sr=? This is the start of fixing some odd dependencies.

what is the difference between aPropFileName and spec ?

aPropFileName is just the string that gets passed in.. in the previous code, we'd take that string (aPropFileName), convert it to a URI object, and then convert it back to a string (spec). From the looks of it, someone wrote this broken code ages ago and the pattern got copied all over the place.

Comment on attachment 50709 [details] [diff] [review] clean up necko stuff and fix APIs to avoid excess conversions r=harishd

Comment on attachment 50709 [details] [diff] [review] clean up necko stuff and fix APIs to avoid excess conversions sr=attinasi

thanks guys, fix is in.