Closed Bug 1017485 Opened 11 years ago Closed 10 years ago

B2G NFC: Enable P2P Listening mode only when screen is on and unlocked.

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S6 (18july)

People

(Reporter: dimi, Assigned: dimi)

References

Details

(Whiteboard: [p=3])

Attachments

(2 files, 1 obsolete file)

After landing bug 984207. NFC is always in listening mode, but we should not listen to p2p connection when screen is off. And we need to define if we allowed listening to p2p when screen is on and locked. If yes, we will require a new API(maybe just an additional config value ) for nfcd to distinguish screen off & locked and screen on & locked
Hi Wesley, Could you help confirm this ?
Flags: needinfo?(whuang)
What I understand is p2p sharing wouldn't be trigger while screen is off. Juwei may be the right person to re-confirm.
Flags: needinfo?(whuang) → needinfo?(jhuang)
I think off-screen p2p has grate opportunities. However, if the restriction is mandatory, nfcd should not take care screen-state directory. how about providing API to filter techtype?
(In reply to Wesley Huang [:wesley_huang] from comment #2) > What I understand is p2p sharing wouldn't be trigger while screen is off. > Juwei may be the right person to re-confirm. The question also includes the behavior when - "Screen ON and Locked"
NFC isn't allowed to p2p as well when screen is on and locked.
Yes. P2P sharing only available when screen in on.
Flags: needinfo?(jhuang)
For security reasons, P2P sharing shouldn't be available when the lockscreen is on, whatever the state of the screen. E.g.: - the phone is in your pocket or in your bag in the locked mode and the screen inadvertently turned on. Whoever comes closer to you can potentially upload some data. - your phone is locked on the side of your desk (at the office, on a coffee shop...), you don't pay attention thinking nobody will be able to access the content of your phone, but somebody taps his phone on yours and upload a malicious link. The issue there is that the link will automatically be displayed on the browser without the user being prompted. This means a malicious script could execute in the browser for instance. The only way we can ensure the user is (probably) aware of the transaction is having him/her unlocking the phone.
(and the screen is on)
Update Summary, should we allow P2P listening when screen is off (and not locked) is TBD.
Summary: [Follow up of Bug 984207] Define timing to enable/disable P2p mode → B2G NFC: Enable P2P Listening mode only when screen is not locked.
Attached file pull request to platofrm_system_nfcd v1 (obsolete) (deleted) —
Attachment #8444920 - Flags: review?(allstars.chh)
Attachment #8444920 - Flags: review?(allstars.chh) → review+
Summary: B2G NFC: Enable P2P Listening mode only when screen is not locked. → B2G NFC: Enable P2P Listening mode only when screen is on and unlocked.
Modify bug description.
Attachment #8444920 - Attachment is obsolete: true
Attachment #8451468 - Flags: review+
Whiteboard: [p=3]
Target Milestone: --- → 2.0 S6 (18july)
It works in flame. Mark checkin-needed
Keywords: checkin-needed
Attachment #8477301 - Flags: review?(allstars.chh)
Attachment #8477301 - Flags: review?(allstars.chh)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: