Quoting a newsgroup posting: --- Subject: Bookmark management wish Date: Thu, 15 Jul 1999 15:00:23 +0100 From: Alien Conspiracy <alien.conspiracy@dial.pipex.com> Organization: Another Netscape Collabra Server User Newsgroups: netscape.public.mozilla.wishlist Hi All, I don't know if this is a common problem or just me, but I often indevertently bookmark pages that are already in my bookmark list. So it would be nice if: (1) There was some on-screen indication as to wether the page currently being viewed is bookmarked or not. (2) The 'add bookmark' command checked the existing bookmarks and warned me if it's a duplicate. Cheers! --- This bug report concerns only the second, warning if adding a duplicate.

don...a nice to have...set to enhancement/M15 for ya.

just doing some housekeeping on the fields.

This seems like a nice feature... but it does not appear to be making the M15 checkpoint. We're in the stability freeze for M15 now... so I'm pushing this off to at least M16

owner seems to be inactive, so i think this bug should be assigned back to don@netscape.com

M16 has been out for a while now, these bugs target milestones need to be updated.

Based on lack of response to Jesse Ruderman's comment above, assigning to default owner and cc:ing previous owner to get bug back on somebody's radar. Clearing M16 since M16 is past.

with workloads as they are there is very little chance any netscaper is going to get to this. this would be a great spot for a mozilla contribution - adding helpwanted keyword.

The "search" sidebar is now mysteriously and quietly excluding the "add to bookmarks" option when you right-click on a link to an existing bookmark. Nothing similar is happening when you right-click a link in the content area. 2000091508 Windows 98

Reassigning to default component owner since slamm isn't here anymore.

nav triage team: Would be nice to have, but don't think we'll do it for beta. Also, need UE to decide if this is worth doing

Marking nsbeta1- bugs as future to get off the radar.

See also bug 10197, "[RFE] Show whether the current page is in the user's bookmarks."

*** Bug 32964 has been marked as a duplicate of this bug. ***

From the duplicate: nsIBookmarksService has a function, IsBookmarked(), that returns PR_TRUE if a URL is already in the user's bookmarks.

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter email notifications caused by this by searching for 'ilikegoats'.

mass reassign of pchen bookmark bugs to ben

nsbeta1+ per Nav triage team, ->1.0. should prevent adding duplicates, not just warn.

Trudelle: > Should prevent adding duplicates, not just warn. I hope you meant that as a temporary workaround for bug 51683 rather than as the desired behavior.

Please update this bug with an [adt1] - [adt3] impact rating (or take it off the list if it doesn't even rate adt3.) Thanks!

Jesse: yes, this is a temporary workaround; we do want to support URLs bookmarked multiple times. ADT3

Since this RFE will prevent a lot of confusion (see bug 51683), I really think it needs to get into 1.0. It seems simple enough to implement (says the non-programmer;-) without creating a lot of new bugs. I've also adding it as a blocker to bug 51683. Even though it doesn't literally block it, it acts as a workaround to that bug.

Very handy. I'm surprized it isn't in yet. Heck, even my napster clone has this functionality for downloading. =)

This would become another worthless dialog which would annoy people who do want the duplicate bookmark, and just be dismissed without being read by everyone else. We don't have a warning on File->Quit for the same reason. Resolving bug 10197 is a much better fix for this, and has the benefit of not desensitizing users to dialogs we really do need. I think if bug 10197 were to be resolved, the demand for this would vanish instantly.

As compromise, perhaps a function in the bookmark manager to check through the bookmarks list and prompt at duplication might do the job nicely..

As a compromise, perhaps a function in the bookmark manager to check through the bookmarks list and prompt at duplication might do the job nicely..

Isn't this bug blocked *BY* bug 51683 rather than a blocker thereof? Even better, it could be blocked by bug 141227 instead. In bug 51683, people are unable to create duplicate bookmarks -- forget about warning them, dupes are what they want! The reason they can't create dupes is because the current incarnation of the Bookmark database is unable to differentiate between bookmarks with the same URL, ie., the behavior you're asking for here is already de-facto.

I think bug 10197 will be a big performance hit and not better than a manual bookmarks search. The way IE does it is perfect, just check all bookmarks (files in IE) in the folder you want to add in.

*** Bug 203857 has been marked as a duplicate of this bug. ***

*** Bug 212022 has been marked as a duplicate of this bug. ***

> This would become another worthless dialog which would annoy people who do want > the duplicate bookmark, and just be dismissed without being read by everyone > else. Says the hardened commandline, anti-GUI Unix user. *I* would very much like this implemented, and indeed would like a preference that *prevents* duplicate bookmarks. I don't want more than one bookmark to the same URL and frankly can see very little use for that feature. If you really want 2 identical bookmarks, you could make it so that they can be seperated by being in different directories. > We don't have a warning on File->Quit for the same reason. When there is more than one tab open, Mozilla most certainly DOES give you a warning :-) > Resolving bug 10197 is a much better fix for this, and has the benefit of not > desensitizing users to dialogs we really do need. No. That bug's far less useful, and most users wouldn't notice some icon telling them that the page is already bookmarked. I suggest adding preference option: 'Allow duplicate bookmarks in the same folder' (unchecked by default), and if it's unchecked, attempting to add a duplicate bookmark to a folder will result in a dialog, similar to IE's, asking whether the user would like to overwrite the existing bookmark.

*** Bug 220049 has been marked as a duplicate of this bug. ***

retargeting

*** Bug 222928 has been marked as a duplicate of this bug. ***

*** Bug 228488 has been marked as a duplicate of this bug. ***

*** Bug 234079 has been marked as a duplicate of this bug. ***

*** Bug 270717 has been marked as a duplicate of this bug. ***

*** Bug 272103 has been marked as a duplicate of this bug. ***

*** Bug 273426 has been marked as a duplicate of this bug. ***

*** Bug 281794 has been marked as a duplicate of this bug. ***

*** Bug 284997 has been marked as a duplicate of this bug. ***

*** Bug 291697 has been marked as a duplicate of this bug. ***

Note: several Firefox bugs were duped to this bug. Firefox bugs should be duped to Bug 220049. Bug 222928 Bug 272103 Bug 281794 Bug 284997 Bug 291697 were the Firefox bugs they are now dupes of Bug 220049.

interesting that the firefox bug 220049 is now marked as "wontfix" while this one for mozilla is not... what's the difference between the two browsers regarding to this functionality?

I'm disappointed that this was originaly flagged (today) as WONTFIX and now continue to be worried that the new classification of enhancement with a priority of P4 means it remains as a WONTFIX.

*** Bug 291844 has been marked as a duplicate of this bug. ***

For those not wanting to wait for the presence of this feature in the core there is Bookmark Duplicate Detector 0.0.1 extension - http://www.extensionsmirror.nl/index.php?showtopic=597 (with maxver bump it would work on FF 1.0).

Bookmark Duplicate Detector doesn't work for me: it scans the _entire_ bookmarks collection for duplicates, while I need only to check for existing bookmarks in the folder in which i'm adding the bookmark. Also in case of existing bookmark it doesn't inform the user about the folder in which the bookmarks is already present. Sometimes I want to bookmark the same page in different folders, and this extension doesn't help me at all. Unfortunately this bug still need to be fixed.

*** Bug 281855 has been marked as a duplicate of this bug. ***

6 YEARS is a long time to wait on something that's seemingly one of the first things that a programmer learns -- look for duplicates in an ASCII file. The add-on isn't perfect in design nor does it work in all releases. As it seems this is a futile request, I'm removing my address to save world-wide Internet bandwidth.

I've just tried the extension "Bookmark Duplicate Detector" with FF 1.5 beta 1 but it doesnt' install. (Install script not found) I've tried fixing the extension without success. In any case the extension is really simple. Why not adding this code directly to FF 1.5 ? It seems trivial. function addBookmarkAs(aBrowser, aIsWebPanel) { var webNav = gBrowser.webNavigation; var url = webNav.currentURI.spec; var isDuplicate = isBookmarked(url); if(isDuplicate) { if(! confirm("This URL is already in your Bookmarks. Do you wish to add it as a duplicate entry?")) return; } const browsers = aBrowser.browsers; if (browsers && browsers.length > 1) addBookmarkForTabBrowser(aBrowser); else addBookmarkForBrowser(aBrowser.webNavigation, aIsWebPanel); } function isBookmarked(url) { if( ! BMDS || ! RDF || ! NC_NS ) { alert("Flagrant Error."); return false; } var urlArc= RDF.GetResource(NC_NS+"URL"); var urlNode= RDF.GetLiteral(url); return BMDS.hasArcIn(urlNode,urlArc); }

This bug depends on bug 18152.

Suggestion. Why not flash the Location Bar and then have an animated arrow appear on the bar that points to the Bookmark symbol at the right. This way the person will know that the page exists iu the bookmarks without having a dialog pop up to tell them.

From Bug 10197, Comment 37 "The "Star bookmark" quick bookmark panel in 2.1b2pre will tell you how many times you've bookmarked the current page." Also, now you can't add duplicate bookmark, more in Bug 789468#c6, so I'm closing this as worksforme