Closed
Bug 102019
Opened 23 years ago
Closed 18 years ago
single word on line placed incorrectly for justified right-to-left (RTL) text
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: waterson, Assigned: uriber)
Details
(Keywords: rtl, testcase)
Attachments
(4 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
When flowing a line of justified, right-to-left text where only a single word
can fit on the line, the word is placed flush left, instead of flush right.
(Note that things work correctly in the case of the _last_ line flowed.)
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Updated•23 years ago
|
Target Milestone: --- → Future
Reporter | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•18 years ago
|
||
Moving to bidi.
Is this a dupe?
Assignee: waterson → nobody
Status: ASSIGNED → NEW
Component: Layout → Layout: BiDi Hebrew & Arabic
QA Contact: chrispetersen → layout.bidi
Summary: single word on line placed incorrectly for justified right-to-left text → single word on line placed incorrectly for justified right-to-left (RTL) text
Comment 3•18 years ago
|
||
I don't think this is a dupe, I don't recall seeing it before.
Assignee | ||
Comment 4•18 years ago
|
||
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #229377 -
Flags: superreview?(dbaron)
Attachment #229377 -
Flags: review?(smontagu)
Comment 5•18 years ago
|
||
Comment on attachment 229377 [details] [diff] [review]
patch
I don't like the code duplication, especially since I suspect you should duplicate it again in the else of "if (!aShrinkWrapWidth)". (I don't know in what circumstances aAllowJustify and aShrinkWrapWidth can both be true).
I would like it better to put a break after ApplyFrameJustification and remove the else from
else if (NS_STYLE_DIRECTION_RTL ...
Comment 6•18 years ago
|
||
... like this.
Uri and I couldn't reach agreement on IRC which version was clearer. At the bottom line, whichever version dbaron prefers has r=smontagu.
Attachment #229379 -
Flags: superreview?(dbaron)
Comment 7•18 years ago
|
||
I think I prefer neither. Why not move the JUSTIFY case up to before the DEFAULT case, and then only break if justification was performed?
Sorry to take so long to get to this.
Comment 8•18 years ago
|
||
This is basically moving code, although I did wrap the overly long line, insert and remove the break statements, and change the comments.
Attachment #248331 -
Flags: review?(smontagu)
Comment 9•18 years ago
|
||
Note also that aShrinkWrapWidth no longer exists post-reflow-branch.
Comment 10•18 years ago
|
||
Comment on attachment 248331 [details] [diff] [review]
how 'bout this?
That's great.
Attachment #248331 -
Flags: review?(smontagu) → review+
Comment 11•18 years ago
|
||
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Attachment #229377 -
Flags: superreview?(dbaron)
Updated•18 years ago
|
Attachment #229379 -
Flags: superreview?(dbaron)
Updated•18 years ago
|
Flags: in-testsuite?
Updated•18 years ago
|
Attachment #229377 -
Flags: review?(smontagu)
Comment 12•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•