the current nsFontPackageHandler opens a window which directs people to mozilla.org. embedded applications should have their own font handlers. It looks like someone started work on this, but it needs to be abstracted out, and the actual nsFontPackageHandler implementation should reside in xpfe/components so that i18n libraries do not have unnecessary dependencies on windowwatcher/etc. patches forthcoming.

also see bug 100204, where I'm doing something similar with the charset menu

oops, make that bug 102004

cc'ing ftang

The second patch also adds the stuff from bug 102004. The files removed have been moved to: http://lxr.mozilla.org/seamonkey/source/xpfe/components/intl/

Comment on attachment 51326 [details] [diff] [review] removal of nsFontPackageHandler, use do_CreateInstance r=ftang

Comment on attachment 51330 [details] [diff] [review] add the new static library to the build r=ftang

Comment on attachment 51330 [details] [diff] [review] add the new static library to the build sr=shaver

Comment on attachment 51326 [details] [diff] [review] removal of nsFontPackageHandler, use do_CreateInstance Thou Shalt Not Put Contract IDs Or Other Implementation Identifiers In IDL Files. Put that sucker in a Utils.h or something (better: don't put it anywhere, as per your thread in .xpcom), and sr=shaver.

hope to land this today if the tree ever opens :)

everything has landed.

Frank, could you or some other one can verify this? Thanks!

We need to remove nsFontPackageHandler.cpp and nsFontPackageHandler.h from \intl\locale\src. alecf: Please remove them. Thanks

I'll remove them, but let's leave the bug how it is, and not make it look like I fixed anything in 0.9.8. The bug is "nsFontPackageHandler should be in xpfe", which it is.

ok. thanks

oh, and I removed the files this morning, after making the comment :)