Closed
Bug 1023688
(CopyPasteLegacy)
Opened 10 years ago
Closed 9 years ago
[META] TouchCaret & SelectionCarets, and text selection/copy/paste support on B2G v2.2
Categories
(Core :: DOM: Selection, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: u459114, Unassigned)
References
Details
(Keywords: meta)
User Story
This is the meta bug for the legacy carets and copy & paste implementation on B2G branch v2.2. To make a feature request or bug report against B2G master, please make it depend on meta bug 1124074 which is for B2G branch v2.5 and above. Please see the wiki page for more information. https://wiki.mozilla.org/Copy_n_Paste
Attachments
(3 files, 2 obsolete files)
A META bug to trace status of text selection/copy/paste support on B2G
Updated•10 years ago
|
Bug 987040 is the main function blocker at this moment
4 main test case blockers.
Bug 1023087 - window manager copy/paste marionette test
Bug 987040 - copy/paste browser API mochitest
Bug 1019441 - selection caret marionette test
Bug 1020261 - touch caret marionette test
We need at least these 4 test cases landed to guarantee basic quality of this feature.
Comment 3•10 years ago
|
||
Hi Morris,
In order to make the selection caret easier to use, I revised the caret images.
Please help me update these images below:
text_caret_tilt_left.png
text_caret_tilt_left@1.5x.png
text_caret_tilt_left@2.25x.png
text_caret_tilt_left@2x.png
text_caret_tilt_right.png
text_caret_tilt_right@1.5x.png
text_caret_tilt_right@2.25x.png
text_caret_tilt_right@2x.png
text_caret.png
text_caret@1.5x.png
text_caret@2.25x.png
text_caret@2x.png
One other thing is that the hightlighting color looks different from the spec, please help me change it to #33b5e5, 40%. Thanks!
Let me know when you finish these adjustment so I can have a UI review :)
Flags: needinfo?(mtseng)
Comment 4•10 years ago
|
||
Hi George,
Text selection Visual spec revised:
Please help adjust the utility menu's shadow.
Shadow: 2px 2px 5px 3px #3d3d3d
Let me know when you're done so I can see if the shadow looks good enough.
Thank you!:)
Flags: needinfo?(gduan)
Updated•10 years ago
|
OS: Gonk (Firefox OS) → Mac OS X
Hardware: All → x86
Updated•10 years ago
|
Flags: needinfo?(gduan)
Updated•10 years ago
|
Flags: needinfo?(mtseng)
Comment 5•10 years ago
|
||
What are the plans for the platform side of things here? We've been working on text selection support on b2g for a while, so I'm aware of that piece, but I'm not sure what our plans are with regards to supporting clipboard for non-text-only content in the content process, etc.
We will work on non-editable content copy and paste after these two bugs land
Bug 987718
Bug 987040
Rich text(non-text-only) copy-paste should be a thing after.
Comment 7•10 years ago
|
||
Please check Bug 921965 to see the latest text selection Visual spec. thanks!!
Comment 8•10 years ago
|
||
Update text caret image assets(png)
Attachment #8439762 -
Attachment is obsolete: true
Updated•10 years ago
|
Assignee: nobody → pchang
Comment 9•10 years ago
|
||
Attaching OS-wide (core apps) text selection rules of thumb and UX guidelines.
Updated•10 years ago
|
Updated•10 years ago
|
Depends on: gaia-copy-paste
Comment 10•10 years ago
|
||
Update UX spec for 2.2.
Comment 11•10 years ago
|
||
(In reply to Omega Feng [:Omega] [:馮於懋] (please ni?) from comment #10)
> Created attachment 8521957 [details]
> FxOS 2.2 UX Spec_Text Selection_v1.3.pdf
>
> Update UX spec for 2.2.
ni Morris, TY for checking the 2.2 UX spec
Flags: needinfo?(tlin)
Flags: needinfo?(mtseng)
Comment 12•10 years ago
|
||
Summarize differences between our implementation right now and ux spec.
Based on spec: https://bugzilla.mozilla.org/attachment.cgi?id=8521957
Page 6, Long press on empty area would select last word.
Page 7, Copy doesn’t hide carets and bubble.
Page 9, Long press on empty field would do nothing.
Page 10, Paste on password field shows unmask for seconds then mask.
Page 12, Right now we’re at “no ok” case.
Page 15, Keyboard always overlap carets.
Page 16, We’ll show “select all” button event if we select all content.
Page 26, Same as page 7, copy doesn’t hide carets and bubble.
Flags: needinfo?(mtseng)
Comment 13•10 years ago
|
||
> Page 7, Copy doesn’t hide carets and bubble.
What I saw is that after copying, carets does not hide, the bubble hides, and the selection does not collapse.
Flags: needinfo?(tlin)
Comment 14•10 years ago
|
||
(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #13)
> > Page 7, Copy doesn’t hide carets and bubble.
> What I saw is that after copying, carets does not hide, the bubble hides,
> and the selection does not collapse.
Ah, right. What I mean is carets doesn't hide and selection range remain un-change.
Comment 15•10 years ago
|
||
(In reply to Morris Tseng [:mtseng] from comment #12)
> Summarize differences between our implementation right now and ux spec.
> Based on spec: https://bugzilla.mozilla.org/attachment.cgi?id=8521957
>
> Page 6, Long press on empty area would select last word.
> Page 7, Copy doesn’t hide carets and bubble.
> Page 9, Long press on empty field would do nothing.
Current the long tap will show the caret on input filed. With my WIP of bug 1068461, it could trigger the touch caert and text dialog.
> Page 10, Paste on password field shows unmask for seconds then mask.
> Page 12, Right now we’re at “no ok” case.
> Page 15, Keyboard always overlap carets.
> Page 16, We’ll show “select all” button event if we select all content.
> Page 26, Same as page 7, copy doesn’t hide carets and bubble.
Updated•10 years ago
|
QA Whiteboard: [2.2-feature-qa+][textselection]
Updated•10 years ago
|
QA Whiteboard: [2.2-feature-qa+][textselection] → [textselection]
Updated•10 years ago
|
QA Whiteboard: [textselection] → [textselection][2.2-feature-qa+]
Updated•10 years ago
|
Flags: in-moztrap?(gchang)
Comment 17•10 years ago
|
||
UX spec update
Password Input: Allow only "Select All" and "Paste" in password input
Attachment #8521957 -
Attachment is obsolete: true
Updated•10 years ago
|
Depends on: CopyPasteGaia
Updated•10 years ago
|
QA Whiteboard: [textselection][2.2-feature-qa+] → [COM=Text Selection][2.2-feature-qa+]
Comment 19•10 years ago
|
||
Test cases are here.
https://moztrap.mozilla.org/manage/cases/?filter-suite=836
Flags: in-moztrap?(gchang) → in-moztrap+
Comment 20•10 years ago
|
||
Is there developer documentation on the mechanism by which the "select all" mechanism operates? In bug 1152172 it appears an unexpected common root is chosen for "select all" which is not what I would expect from the documentation at https://developer.mozilla.org/en-US/docs/Web/CSS/user-select. (And I couldn't find any better sources in a cursory searching of MDN, and there appear to be no normative implementation references here other than the attached UX specs that don't address this situation.)
Comment 21•10 years ago
|
||
As a follow-up, I've started a thread on dev.gaia about whether the current "select all" implementation should operate as it does since I was surprised that it really tries to select everything: https://groups.google.com/forum/#!topic/mozilla.dev.gaia/3tBQxCN5INQ
Updated•9 years ago
|
Alias: CopyPaste → CopyPasteLegacy
Assignee: howareyou322 → nobody
Summary: [META] Text selection/copy/paste support on B2G → [META] TouchCaret & SelectionCarets, and text selection/copy/paste support on B2G v2.2
Updated•9 years ago
|
User Story: (updated)
Updated•9 years ago
|
User Story: (updated)
Updated•9 years ago
|
Comment 22•9 years ago
|
||
The touch/selection carets in gecko, related event handling in browser-element, and text_selection_dialog.js in Gaia had been removed. This old meta bug is now officially retired, and the new meta bug is Bug 1124074. Thank you all for helping.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•