Closed Bug 1024830 Opened 10 years ago Closed 5 years ago

Allow vertical clipping of New Tab page thumbnails when browser.pagethumbnails.capturing_disabled is true and browser.newtabpage.rows value greatly outnumbers browser.newtabpage.columns

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mardeg, Unassigned)

References

Details

(Keywords: regression)

Before Firefox 31 I had set the new tab page grid to 13 rows by 2 columns which effectively hid the blank thumbnails while still clearly showing the text of each to click on. Bug 978338 broke that behaviour, resulting in a 3 rows by 2 columns grid. This bug is to make the behaviour dependent upon the values of these prefs: So keep the current height/width ratio of thumbnails, UNLESS: browser.pagethumbnails.capturing_disabled is set to true, AND browser.newtabpage.rows has a value much greater than (at least 3X or 4X) the value of browser.newtabpage.columns upon which the new tab page should revert to the previous behaviour: allowing thumbnails to be clipped vertically (given they are blank anyway)
Either obey browser.newtabpage.rows/columns or remove the prefs. I would prefer they were obeyed.
(In reply to Jesper Hansen from comment #1) > Either obey browser.newtabpage.rows/columns Bug 1005596 was filed to obey the prefs, but specifically only when zoomed out and keeping the ratios without clipping. > Either obey browser.newtabpage.rows/columns > or remove the prefs. I would prefer they were obeyed. Bug 1026561 has been filed to remove the prefs.

Hello!

This bug has been closed due to inactivity and/or the potential for this bug to no longer be an issue with the new Discovery Stream-powered New Tab experience.

Please help us triage by reopening if this issue still persists and should be addressed.

Thanks!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.