We have tons of deprecated FILL_PARENT usages in our tree: http://mxr.mozilla.org/mozilla-central/search?string=fill_parent&find=base&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central These should all be switched to MATCH_PARENT.

Occurrences of "fill_parent" have been replaced with "match_parent", and occurrences of FILL_PARENT with MATCH_PARENT.

Replaced occurrences of fill_parent with match_parent in the XML files, and FILL_PARENT with MATCH_PARENT in the .java files.

Comment on attachment 8443443 [details] [diff] [review] 1027831.patch - Replaced occurrences of fill_parent with match_parent, and FILL_PARENT with MATCH_PARENT Review of attachment 8443443 [details] [diff] [review]: ----------------------------------------------------------------- Looks perfect, thanks!

Thanks! This is my first bug fix. Could you please help me push this code? Is there anything I need to do to make it happen?

I already took care of that for you in comment 4. :) Normally, you would ask for try server access (https://tbpl.mozilla.org/?tree=Try), push your patch there to make sure it passes all of our tests, then set the checkin-needed flag in the bug for a volunteer to land for you. In this case, however, you have a patch that touches many files, so I wanted to land it ASAP to minimize bitrot. The changes in the patch are also quite trivial, and have a very low chance of breaking anything.