Closed
Bug 1028141
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of CSF::AudioControl
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: bjacob, Assigned: mccr8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
abr
:
review+
|
Details | Diff | Splinter Review |
In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.
One of them is: CSF::AudioControl
Flags: needinfo?(rjesup)
|
Assignee | |
Comment 1•10 years ago
|
||
It seems weird that AudioControlWrapper both inherits from AudioControl, and has a pointer to an instance of AudioControl, but ok.
Assignee: nobody → continuation
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8464354 -
Flags: review?(adam)
|
||
Comment 3•10 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #1)
> It seems weird that AudioControlWrapper both inherits from AudioControl, and
> has a pointer to an instance of AudioControl, but ok.
Those teeth were like that when we were gifted this horse... :)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8464354 [details] [diff] [review]
Remove dangerous public destructor of CSF::AudioControl.
Review of attachment 8464354 [details] [diff] [review]:
-----------------------------------------------------------------
looks fine.
Attachment #8464354 -
Flags: review?(adam) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Flags: needinfo?(rjesup)
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•