Closed Bug 102870 Opened 23 years ago Closed 23 years ago

should gfx know internals of imagelib?

Categories

(Core Graveyard :: Image: Painting, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID
mozilla1.0.1

People

(Reporter: jonsmirl, Assigned: pavlov)

References

Details

gfx has these methods: NS_IMETHOD DrawImage(imgIContainer *aImage, const nsRect * aSrcRect, const nsPoint * aDestPoint) = 0; This code lives inside gfx and extracts the nsIImage via calls to imagelib. gfx also has these methods: NS_IMETHOD DrawImage(nsIImage *aImage, nscoord aX, nscoord aY, nscoord aWidth, nscoord aHeight) = 0; Should the imgIContainer calls be removed from gfx? Calls with a container would be replaced with something like this: gfx:DrawImage(getter_AddRefs(container->getSnapshot()), ....) This breaks the linkage between imagelib and gfx. gfx then doesn't have to know how to extract a snapshot out of a container.
Blocks: 100107
accepting for mozilla 1.0
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Blocks: 106686
No longer blocks: 100107
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
Moving bugs to new Image: GFX component
Component: ImageLib → Image: GFX
no, the fact that imagelib currently has a nsIImage instead the imgIContainer is an implementation detail. gfx doesn't really know the internals of imagelib and I think this is ok. Anyways, gfx and gfx2 should get along and it is ok for them to know how each other work, and gfx is simply talking to gfx2 to get this information.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → INVALID
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.