Closed Bug 1029678 Opened 10 years ago Closed 2 years ago

unified build fails in extensions/spellcheck/src & extensions/spellcheck/hunspell/src

Categories

(Core :: Spelling checker, defect)

Product:
Core
Component:
Spelling checker
Platform:
x86_64
Windows 8
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ally, Unassigned)

References

Details

follow up bug from Bug 693555 where unified build UNIFIED_SOURCES had to be changed to SOURCES. It was traced to the behavior of upstream header <windows.h> Part of the window.h problems were mitigated by https://hg.mozilla.org/integration/mozilla-inbound/rev/6aa850be63ea#l1.5, but we've been unable to puzzle this one out.
Blocks: unified
Component: XUL Widgets → Spelling checker
Product: Toolkit → Core
The issue we got stuck on is |near| being #defined by windows.h, and then later on being used by other stuff, which means we can't just #undef near around the link in comment 0...
Severity: normal → S3

Both extensions/spellcheck/src/moz.build and extensions/spellcheck/hunspell/src/moz.build now use UNIFIED_SOURCES , I think it's fine to close this bug.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.