Closed
Bug 1030602
Opened 10 years ago
Closed 10 years ago
Remove extra WebICC dom APIs
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: dgarnerlee, Assigned: dgarnerlee)
References
Details
(Whiteboard: [ETA: 12/15])
Attachments
(2 files, 4 obsolete files)
(deleted),
text/x-github-pull-request
|
alive
:
review+
|
Details |
(deleted),
patch
|
Details | Diff | Splinter Review |
There doesn't seem to be any (direct) users of the exchangeAPDU commands in gaia/apps, which target the SIM.
They are being replaced with newer Secure Element API proposals:
https://bug879861.bugzilla.mozilla.org/attachment.cgi?id=8444259
We should remove them as a prereq.
Assignee | ||
Comment 1•10 years ago
|
||
Removal try results:
https://tbpl.mozilla.org/?tree=Try&rev=0b2f004a967e
Assignee: nobody → dgarnerlee
Status: NEW → ASSIGNED
Attachment #8448961 -
Flags: review?(allstars.chh)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8448961 [details] [diff] [review]
Bug 1030602: Remove extra MozICC dom APIs (Gecko side)
Review of attachment 8448961 [details] [diff] [review]:
-----------------------------------------------------------------
I think you only need to remove the public Web API, not for the internal API and Impl.
Attachment #8448961 -
Flags: review?(allstars.chh) → review-
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Yoshi Huang[:allstars.chh] from comment #3)
> Comment on attachment 8448961 [details] [diff] [review]
> Bug 1030602: Remove extra MozICC dom APIs (Gecko side)
>
> Review of attachment 8448961 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I think you only need to remove the public Web API, not for the internal API
> and Impl.
I'm not sure we can keep the internals? However, keeping some internals might be useful for reference during implementation.
The new proposed SE API has different usage, names and parameters. For example:
IccProvider:
iccOpenChannel --> MozSESession: openLogicalChannel(aid)
iccExchangeAPDU --> MozSEChannel: transmit(MozSECommand)
iccCloseChannel --> MozSESession/MozSEChannel: close()
Updated•10 years ago
|
Whiteboard: [ETA: 12/15]
Assignee | ||
Comment 6•10 years ago
|
||
Bug 879861 will be a new version of Icc API, and will obsolete this bug.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Bug 879861 is for 'Secure Element', Component: NFC, not for ICC,
This bug is filed for the ICC part, that's why seperated bugs are filed.
Also you have requested r?, reviewer has already spent time on looking your patch.
Next time please discuss with reviewer.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 8•10 years ago
|
||
Noted. I spoke to Sid before duping it. I'll submit just the MozICC webidl removal, since it's completely obsolete (SE will also modify the interal Icc idl for removing window, so I won't touch that).
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8448965 [details]
Bug 1030602: Remove unused ICC dom APIs (Gaia)
https://github.com/mozilla-b2g/gaia/pull/25190
Attachment #8448965 -
Flags: review?(alive)
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8448965 [details]
Bug 1030602: Remove unused ICC dom APIs (Gaia)
https://github.com/mozilla-b2g/gaia/pull/25190
Assignee | ||
Comment 11•10 years ago
|
||
Recreate attachment.
Attachment #8448965 -
Attachment is obsolete: true
Attachment #8448965 -
Flags: review?(alive)
Attachment #8505809 -
Flags: review?(alive)
Comment 12•10 years ago
|
||
Comment on attachment 8505809 [details]
Bug 1030602: Remove unused ICC dom APIs (Gaia)
r+ if it's really deprecated. No one tells why so I assume they are blocking the Secure Element feature.
Attachment #8505809 -
Flags: review?(alive) → review+
Assignee | ||
Comment 13•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #12)
> Comment on attachment 8505809 [details]
> Bug 1030602: Remove unused ICC dom APIs (Gaia)
>
> r+ if it's really deprecated. No one tells why so I assume they are blocking
> the Secure Element feature.
Thanks. There will be dev hardware support attached to the other end of the API in the new Secure Element API. It will have, among other things, access control, unlike the old one exposed through a WebIDL (originally for a modified Nexus S image).
Assignee | ||
Comment 14•10 years ago
|
||
Gecko side: remove the open/close/transceive DOM API. Try results: https://tbpl.mozilla.org/?tree=Try&rev=2c58d160e9a8
Attachment #8448961 -
Attachment is obsolete: true
Attachment #8506479 -
Flags: review?(allstars.chh)
Attachment #8506479 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Comment 15•10 years ago
|
||
Gaia's Gij seems to be timing out frequently, though it passed once.
Keywords: checkin-needed
Comment 16•10 years ago
|
||
remote: WebIDL file dom/webidl/MozIcc.webidl altered in changeset fd26f977e331 without DOM peer review
so it needs dom peer review, thanks!
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Attachment #8506479 -
Flags: superreview?(bugs)
Updated•10 years ago
|
Attachment #8506479 -
Flags: superreview?(bugs) → superreview+
Assignee | ||
Comment 17•10 years ago
|
||
Thanks. Updated patch subject with review tags.
Attachment #8506479 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 19•10 years ago
|
||
Keywords: checkin-needed
Comment 20•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•