- two stamp taken before we've detected a QPC misbehavior, contain GTC+QPC values - count duration from them, value is X1 - drop the use-QPC flag to false - count duration from the two stamps again, value is X2 and X2 <> X1 This can be easily changed, when both stamps have the QPC value stored and it's found sane, use it for the duration calculation regardless the QPC flag. The patch moves the if (!useQPC) return GTC1-GTC2; way after we do the initial QPC vs GTC sanity checks. Now the result is independent of the useQPC global flag changes.

Comment on attachment 8451028 [details] [diff] [review] v1 Review of attachment 8451028 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay. That is a good case to consider! Any way to write a unit test for it? It seems nicely self contained.

(In reply to Rob Arnold [:robarnold] from comment #1) > Comment on attachment 8451028 [details] [diff] [review] > v1 > > Review of attachment 8451028 [details] [diff] [review]: > ----------------------------------------------------------------- > > Sorry for the delay. That is a good case to consider! Any way to write a > unit test for it? It seems nicely self contained. I absolutely don't know how to write a test for this, sorry. Thanks for the review.