Closed Bug 1035661 Opened 10 years ago Closed 9 years ago

Test browser_inspector_scrolling.js isn't doing anything useful for the devtools

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(1 file)

This test is scrolling an iframe, then checking that the iframe did scroll. It doesn't look like it's anything useful for the devtools. Here is the original version: http://hg.mozilla.org/mozilla-central/annotate/132d2e88ef03/browser/devtools/inspector/test/browser_inspector_scrolling.js which shows it was always this way. It could be that the highlighter used to block scrolling somehow and this test was here to avoid it from happening again. In any case, the new highlighter doesn't listen for scroll events anymore, so this looks like it's a useless test for the devtools. We should repurpose the test so it checks that the highlighter follows the scrolled DIV instead, this would make sense.
Better wait for bug 988314 to be done first as it rewrites all inspector tests.
Depends on: 988314
Assignee: nobody → mratcliffe
@pbrosset: Do you still think this test should be removed? Filter on 1ff0543e-b501-4893-a72b-e4773c01e655
Assignee: mratcliffe → nobody
Flags: needinfo?(pbrosset)
Yes I do.
Flags: needinfo?(pbrosset)
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment on attachment 8723063 [details] MozReview Request: Bug 1035661 - Remove useless test browser_inspector_scrolling.js; r=miker https://reviewboard.mozilla.org/r/36323/#review32903
Attachment #8723063 - Flags: review?(mratcliffe) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: