Closed
Bug 1038990
Opened 10 years ago
Closed 10 years ago
Add a border on both side of the tab bar when using a lightweight theme
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: zfang, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Gijs
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1015157 +++
Implement the solution in bug 1015157 on Windows 7 & 8
Flags: firefox-backlog+
Updated•10 years ago
|
Points: --- → 5
QA Whiteboard: [qa+]
Comment 1•10 years ago
|
||
Note that it's possible that bug 672885 (blocking bug 590945) is not an issue for Windows 8 (which uses newer DirectX) so we may be able to do Window frame stuff (like bug 590945) for Win8+.
Updated•10 years ago
|
QA Whiteboard: [qa+]
Flags: qe-verify+
Comment 2•10 years ago
|
||
If I read bug 1015157 comment 6 correctly, the only thing we need to do here is add a grey border to the left and right side of the tab bar. Philipp, is that right?
Flags: needinfo?(philipp)
Comment 3•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #2)
> If I read bug 1015157 comment 6 correctly, the only thing we need to do here
> is add a grey border to the left and right side of the tab bar. Philipp, is
> that right?
Yes that's the main thing. Note that this is only for Windows 7 and 8 though.
I just saw that Zhenshuo didn't include a mockup for Windows XP in the bug (round corners on the theme would be really helpful there), but I can find that.
Flags: needinfo?(philipp)
Updated•10 years ago
|
Assignee: nobody → dao
Status: NEW → ASSIGNED
Iteration: --- → 35.2
Updated•10 years ago
|
QA Contact: cornel.ionce
Assignee | ||
Updated•10 years ago
|
Component: Toolbars and Customization → Theme
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8493687 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 5•10 years ago
|
||
Hmm, I'm not sure if ::after:not(:-moz-lwtheme) works. Changed to :not(:-moz-lwtheme)::after.
Attachment #8493687 -
Attachment is obsolete: true
Attachment #8493687 -
Flags: review?(gijskruitbosch+bugs)
Attachment #8493688 -
Flags: review?(gijskruitbosch+bugs)
Comment 6•10 years ago
|
||
Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff
Review of attachment 8493688 [details] [diff] [review]:
-----------------------------------------------------------------
With my apologies for the delay here.
This looks kind of awkward in the top-left corner because of the top border we use for lwthemes... but I'm not really sure how to fix that, and I think this is a strict improvement, so let's at least take this.
Attachment #8493688 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Hardware: x86 → All
Summary: Implement quick visual fixes for lightweight theme display on Windows → Add a border on both side of the tab bar when using a lightweight theme
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment 9•10 years ago
|
||
Verified fixed on latest Nightly, build ID: 20140925030203
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff
Approval Request Comment
[Feature/regressing bug #]: part of the effort to promote lightweight themes in customization mode
[User impact if declined]: see bug 1015157 comment 6 (first point)
[Describe test coverage new/current, TBPL]: no tests
[Risks and why]: small CSS-only change, low risk
[String/UUID change made/needed]: none
Attachment #8493688 -
Flags: approval-mozilla-aurora?
Comment 11•10 years ago
|
||
Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff
Aurora+
Attachment #8493688 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
status-firefox34:
--- → affected
status-firefox35:
--- → fixed
Comment 12•10 years ago
|
||
Comment 13•10 years ago
|
||
Verified on Nightly in comment 9.
Comment 14•10 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (X11; Linux i686; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Verified fixed on latest Aurora, build ID: 20140930004006.
status-firefox33:
--- → verified
Updated•10 years ago
|
status-firefox33:
verified → ---
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•8 years ago
|
OS: All → Windows
You need to log in
before you can comment on or make changes to this bug.
Description
•