Closed Bug 1040 Opened 26 years ago Closed 26 years ago

CSS vertical-align problems; reflow strange

Categories

(Core :: CSS Parsing and Computation, defect, P2)

x86
Other
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: buster)

References

()

Details

vertical-align: middle (bug 606, maybe), vertical-align: text-bottom (I'm not sure about this one), and vertical-align: 50% do not work.‰
Summary: CSS vertical-align → CSS vertical-align problems; reflow strange
Oh... forgot to mention - the reflow of this page is a bit weird as the images are loading.‰
Status: NEW → ASSIGNED
I think 50% is now OK, and middle is definitely fixed, but now I think text-top is also wrong. I'm not completely sure, but my current thinking is that text- top and text-bottom are now the ones wrong.‰
Assignee: peterl → kipp
Status: ASSIGNED → NEW
The only case that looked wrong to me is "bottom-aligned" (it looks like it's acting like "text-bottom-aligned"
Status: NEW → ASSIGNED
I think this is all fixed, except that the alignment of the image is a bit strange in the bottom and the text-bottom align tests. (The image has no given alignment, so it should be baseline aligned with its parent.) This refers to the new version of the test suite, which should be at that above URL soon -- the test is a bit different.
Setting all current Open/Normal to M4.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
This test now passes gloriously. The problems were: handling of margins around inline elements when vertically aligning; handling of the line-height property
Status: RESOLVED → VERIFIED
Verified fixed. There could be some 1px error issues, but I'll address them in bug 1990, which has a better test for that.
You need to log in before you can comment on or make changes to this bug.