I think Michael was going to work on this/had a prototype?

I was mistaken - taking.

ok, this does a bit more than the bug says, but I think you'll agree it needed to be done :) I expect this to break a few tests, but it's easier for me to wait for the try server than run them all locally - I'll fix them as they come in.

Comment on attachment 8461650 [details] Allow notifications to be dismissed with a leftward swipe Awesome! This is so much nicer than it used to be. Code looks good too, I left a small comment on github about possibly getting rid of some old code, but r+. One small issue I found is if a user starts swiping the notification toaster, and then we hit the toaster timeout while swiping, which makes the toaster disappear. It looks like the user swiped away the notification, but instead the notification stays in the tray. I think this is an edge case though.

(In reply to Michael Henretty [:mhenretty] from comment #4) > Comment on attachment 8461650 [details] > Allow notifications to be dismissed with a leftward swipe > > Awesome! This is so much nicer than it used to be. Code looks good too, I > left a small comment on github about possibly getting rid of some old code, > but r+. > > One small issue I found is if a user starts swiping the notification > toaster, and then we hit the toaster timeout while swiping, which makes the > toaster disappear. It looks like the user swiped away the notification, but > instead the notification stays in the tray. I think this is an edge case > though. I'll remove the gesture detectors, thanks for the notes :) I'm going to leave the toaster bits, I notice they miss any transitions entirely, so I think a separate bug about toaster transitions would be a better place to fix this (I'll file this).

Merged with master: https://github.com/mozilla-b2g/gaia/commit/58242f4d34493a412907663513d935c1ddf19fd5 Was hitting what appears to be an unrelated failure (bug 1043870) so took the risk.