From change https://bugzilla.mozilla.org/show_bug.cgi?id=1038601, HashTable::mutationCount is declared conditionally based on the JS_DEBUG pound define [1] but used conditionally by DEBUG pound define [2]. In some builds, DEBUG is defined but JS_DEBUG is not. Perhaps mutationCount should be pulled out and wrapped by DEBUG instead. [1] https://github.com/mozilla/gecko-dev/blob/256a1f168b345758d1ce83f6575d6543f8bec738/js/public/HashTable.h#L1005 [2] https://github.com/mozilla/gecko-dev/blob/256a1f168b345758d1ce83f6575d6543f8bec738/js/public/HashTable.h#L1089

Oh, since I've posted a fix patch as a follow-up in bug 1038601, how about we just continue things there?

I'm reopening this bug because a patch has already landed in bug 1038601. It's confusing to post follow-up patches to bugs that are already RESOLVED.

Moving the patch from bug 1038601 to here.

Comment on attachment 8470641 [details] [diff] [review] Fix up DEBUG/JS_DEBUG confusion in HashTable.h Review of attachment 8470641 [details] [diff] [review]: ----------------------------------------------------------------- Carrying over r+ from bug bug 1038601.

Ta!