Closed Bug 1046320 Opened 10 years ago Closed 10 years ago

Add idl to set up public key pins to PublicKeyPinningService

Categories

(Core :: Security: PSM, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 787133

People

(Reporter: cviecco, Unassigned)

References

Details

Attachments

(1 file)

This bug is to add an idl to and a memory only store PublicKeyPinningService so that public key pins can be added via xpcom calls. The store must be thread safe.
Blocks: hpkp
Attached patch add-pkservice-idl (deleted) — Splinter Review
Comment on attachment 8466465 [details] [diff] [review] add-pkservice-idl Review of attachment 8466465 [details] [diff] [review]: ----------------------------------------------------------------- So I was thinking about this interface. What do you think (maybe the insert is redundant?)
Attachment #8466465 - Flags: feedback?(dkeeler)
Comment on attachment 8466465 [details] [diff] [review] add-pkservice-idl Review of attachment 8466465 [details] [diff] [review]: ----------------------------------------------------------------- Why not just use nsISiteSecurityService? It already can parse headers similar to HPKP.
Attachment #8466465 - Flags: feedback?(dkeeler) → feedback-
(In reply to David Keeler (:keeler) [use needinfo?] from comment #3) > Comment on attachment 8466465 [details] [diff] [review] > add-pkservice-idl > > Review of attachment 8466465 [details] [diff] [review]: > ----------------------------------------------------------------- > > Why not just use nsISiteSecurityService? It already can parse headers > similar to HPKP. Because this inferface is specific to public pins and I am no interested in parsing at this moment. Also, nsISiteSecurityService is not thread safe (to my understanding) for accesing its information as it currently uses the site preferences.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: