Closed
Bug 1049029
Opened 10 years ago
Closed 10 years ago
DevTools Themes: Remove hover and active state on active sidebar tab (dark theme)
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox34 verified)
VERIFIED
FIXED
Firefox 34
| Tracking | Status | |
|---|---|---|
| firefox34 | --- | verified |
People
(Reporter: me, Assigned: me, Mentored)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
When I solved Bug 929127, I added :hover and :active states to the active tab on dark theme. Since in the light theme the active tab color doesn't change on hover, I think in the dark theme it shouldn't either.
|
Assignee | |
Updated•10 years ago
|
|
||
Comment 1•10 years ago
|
||
Agreed, since reselecting on the tab doesn't do anything there is no reason to show hover/active states
|
|
Assignee | |
Comment 2•10 years ago
|
||
I think that's all.
Attachment #8470462 -
Flags: review?(bgrinstead)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8470462 [details] [diff] [review]
bug1049029.patch
Review of attachment 8470462 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great
Attachment #8470462 -
Flags: review?(bgrinstead) → review+
|
|
||
Comment 4•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
|
||
Comment 6•10 years ago
|
||
Verified: [bugday-20140813]
Fixed in Windows 7 32-bit OS Firefox Nightly 34.
Explanation:
Hover on active sidebar does not change color.
QA Whiteboard: [qa+]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•