Closed Bug 1049565 Opened 10 years ago Closed 10 years ago

The 'Back' button is grayed out after selecting the 'sad' icon

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Platform:
x86_64
Windows 7
Type:
defect

Tracking

(firefox34 verified, firefox35 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox34 --- verified
firefox35 --- verified

People

(Reporter: pauly, Assigned: aoprea)

References

Details

(Whiteboard: [regression][loop-uplift][fig:verified])

Attachments

(2 files)

loop - back button grayed out.png
(deleted), image/png
Details
Update style for feedback form back button
(deleted), patch
NiKo
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
STR: 1. Perform a 1:1 call 2. End the call 3. Click on the 'sad' icon to provide feedback 4. Look at the 'Back' button on the top Actual results: 'Back" button is grayed out, but functional
Attached image loop - back button grayed out.png (deleted) —
Looks to be a regression from landing bug 972992
Priority: -- → P1
Whiteboard: [regression]
Target Milestone: --- → mozilla34
Yep, lets get Darrin's feedback here.
Flags: needinfo?(dhenein)
Agreed -- I thought it looked OK in my spec but seeing it here it needs to be darker. Lets make the border #AAA and the text #777. Also the button background should match the panel background, essentially being transparent.
Flags: needinfo?(dhenein)
QA Contact: aoprea
Assignee: nobody → aoprea
QA Contact: aoprea
Attachment #8486221 - Flags: review?(nperriault)
Comment on attachment 8486221 [details] [diff] [review] Update style for feedback form back button Review of attachment 8486221 [details] [diff] [review]: ----------------------------------------------------------------- Looks good :)
Attachment #8486221 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/mozilla-central/rev/51cabe253d11
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: mozilla34 → mozilla35
Verified fixed 35.0a1 (2014-09-10) Win 7, OS X 10.9.5, Ubuntu 12.10
Status: RESOLVED → VERIFIED
status-firefox35: --- → verified
Whiteboard: [regression] → [regression][loop-uplift]
Flags: qe-verify+
Flags: in-moztrap-
Paul can you please test this again across platforms using the following Try-server build? http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rjesup@wgate.com-f9eb2cbac352
Flags: needinfo?(paul.silaghi)
QA Contact: paul.silaghi
Whiteboard: [regression][loop-uplift] → [regression][loop-uplift][fig:verifyme]
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #11) > Paul can you please test this again across platforms using the following > Try-server build? > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rjesup@wgate.com- > f9eb2cbac352 Verified fixed Win 7, OS X 10.9.5, Ubuntu 13.04
Flags: needinfo?(paul.silaghi)
Whiteboard: [regression][loop-uplift][fig:verifyme] → [regression][loop-uplift][fig:verified]
Comment on attachment 8486221 [details] [diff] [review] Update style for feedback form back button Approval Request Comment Uplift request for patches staged and tested on Fig
Attachment #8486221 - Flags: approval-mozilla-aurora?
Comment on attachment 8486221 [details] [diff] [review] Update style for feedback form back button I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8486221 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Paul, can you please verify this in Aurora now that it's been uplifted?
Flags: needinfo?(paul.silaghi)
Verified fixed FF 34b1 OS X 10.9.5
status-firefox34: fixed → verified
Flags: needinfo?(paul.silaghi)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: