Closed
Bug 1050276
Opened 10 years ago
Closed 10 years ago
Useless scrollbars in the feedback window
Categories
(Hello (Loop) :: Client, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: pauly, Unassigned)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
dmosedale
:
review-
|
Details | Diff | Splinter Review |
loop feedback scrollbars.png
STR:
1. Perform a 1:1 call
2. End the call from the person who starts the call side
Actual results:
Horizontal scrollbar after ending the call, on the callee side.
Vertical scrollbar after clicking the 'sad' icon
Hides scrollbars in the conversation window.
Attachment #8469274 -
Flags: review?(standard8)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8469274 [details] [diff] [review]
Fixed unwanted scrollbars in Loop conversation window.
I'm a little concerned this is a wallpaper approach and we should just fix our styles on Windows.
As I'm not sure, bouncing to Dan to get his thoughts here.
Attachment #8469274 -
Flags: review?(standard8) → review?(dmose)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8469274 [details] [diff] [review]
Fixed unwanted scrollbars in Loop conversation window.
Review of attachment 8469274 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not a huge fan of this approach. Let's first see whether this is still a problem after part two of bug 1048938 lands. If it is, let's at least get someone with a windows build/VM to try and debug this a bit before we fall back to this approach.
Attachment #8469274 -
Flags: review?(dmose) → review-
|
||
Comment 4•10 years ago
|
||
I believe this was fixed by Bug 1048938.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
|
Reporter | |
Comment 5•10 years ago
|
||
The second scrollbar (when selecting the 'sad' icon) is still displayed
You need to log in
before you can comment on or make changes to this bug.
Description
•