Closed
Bug 1051872
Opened 10 years ago
Closed 10 years ago
media GMP addon gets installed during jetpack test run..
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zombie, Assigned: mossop)
References
Details
Attachments
(1 file)
i think it's the new addon for doing DRM stuff..
this is how :gfritzsche says we should disable it:
http://mxr.mozilla.org/mozilla-central/search?string=%2Fdummy.xml&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
|
||
Comment 1•10 years ago
|
||
GMP is the GeckoMediaPlugins, which are now used for OpenH264 (and later for EME and other things):
https://wiki.mozilla.org/GeckoMediaPlugins
QA Contact: georg.fritzsche
|
Assignee | |
Comment 2•10 years ago
|
||
Should be solved by bug 1035512 I think
Depends on: sdk-mochitestification-fx
|
|
Assignee | |
Comment 3•10 years ago
|
||
So bug 1030036 apparently did this, but we still see a lot of promise rejection failures from GMPInstallManager.
Depends on: 1030036
|
|
Assignee | |
Comment 4•10 years ago
|
||
This disabled attempts to update the GMP plugin solving most of the promise rejection failures in our tests.
Assignee: nobody → dtownsend+bugmail
Attachment #8473797 -
Flags: review?(evold)
|
Reporter | |
Comment 5•10 years ago
|
||
(In reply to Dave Townsend [:mossop] from comment #3)
> So bug 1030036 apparently did this, but we still see a lot of promise
> rejection failures from GMPInstallManager.
that just disabled the outbound update request, but now the install check fails and browser.js doesn't handle the Promise rejection:
http://dxr.mozilla.org/mozilla-central/source/toolkit/modules/GMPInstallManager.jsm#477
http://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1343
|
|
Reporter | |
Comment 6•10 years ago
|
||
Comment on attachment 8473797 [details]
patch
just tracked down the exact same thing, so i can r+..
Attachment #8473797 -
Flags: review?(evold) → review+
|
||
Comment 7•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/97d98bbd18b6a8824f2613428fbfcd7be46cf349
Bug 1051872: Disable GMP auto updates.
https://github.com/mozilla/addon-sdk/commit/b632537d8782b2f55c915d7cf5f4760bb6d12c5e
Merge pull request #1588 from Mossop/bug1051872
Bug 1051872: Disable GMP auto updates. r=zombie
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•