Closed Bug 1055499 Opened 10 years ago Closed 10 years ago

Intermittent browser_styleeditor_fetch-from-cache.js | leaked 2 window(s) until shutdown (and many more)

Tracking

(firefox32 fixed, firefox33 fixed, firefox34 fixed, firefox-esr24 unaffected, firefox-esr31 fixed)

Status:

RESOLVED FIXED

Milestone:

Firefox 34

Tracking Flags:

Tracking

Status

firefox32

---

fixed

firefox33

---

fixed

firefox34

---

fixed

firefox-esr24

---

unaffected

firefox-esr31

---

fixed

People

(Reporter: emorley, Assigned: sjakthol)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

styleeditor-test-toolbox-cleanup.patch 10 years ago Sami Jaktholm (deleted), patch	harth : review+	Details \| Diff \| Splinter Review

Ed Morley [:emorley]

Reporter

Description

•

10 years ago

Rev5 MacOSX Mountain Lion 10.8 fx-team debug test mochitest-devtools-chrome-3 on 2014-08-18 17:04:15 PDT for push f8bb07dbe641 slave: talos-mtnlion-r5-023 https://tbpl.mozilla.org/php/getParsedLog.php?id=46215687&tree=Fx-Team { 17:32:05 INFO - 28432 INFO TEST-OK | chrome://mochitests/content/browser/toolkit/devtools/server/tests/browser/browser_storage_updates.js | took 8756ms 17:32:05 INFO - 28433 INFO ++DOCSHELL 0x10f368000 == 10 [pid = 1294] [id = 3036] 17:32:05 INFO - 28434 INFO ++DOMWINDOW == 25 (0x10f840000) [pid = 1294] [serial = 6866] [outer = 0x0] 17:32:05 INFO - 28435 INFO ++DOMWINDOW == 26 (0x114469000) [pid = 1294] [serial = 6867] [outer = 0x10f840000] 17:32:05 INFO - 28436 INFO [1294] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/fx-team-osx64-d-00000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265 17:32:06 INFO - 28437 INFO [1294] WARNING: Subdocument container has no frame: file /builds/slave/fx-team-osx64-d-00000000000000/build/layout/base/nsDocumentViewer.cpp, line 2515 17:32:06 INFO - 28438 INFO ++DOMWINDOW == 27 (0x10f3d1400) [pid = 1294] [serial = 6868] [outer = 0x1152b4400] 17:32:06 INFO - 28439 INFO [1294] WARNING: Subdocument container has no frame: file /builds/slave/fx-team-osx64-d-00000000000000/build/layout/base/nsDocumentViewer.cpp, line 2515 17:32:06 INFO - 28440 INFO ++DOMWINDOW == 28 (0x114e02c00) [pid = 1294] [serial = 6869] [outer = 0x1152b4800] 17:32:06 INFO - 28441 INFO --DOCSHELL 0x113787000 == 9 [pid = 1294] [id = 13] 17:32:06 INFO - 28442 INFO [1294] WARNING: Subdocument container has no frame: file /builds/slave/fx-team-osx64-d-00000000000000/build/layout/base/nsDocumentViewer.cpp, line 2515 17:32:06 INFO - 28443 INFO ++DOMWINDOW == 29 (0x10dbebc00) [pid = 1294] [serial = 6870] [outer = 0x1152b4400] 17:32:07 INFO - 28444 INFO [1294] WARNING: Subdocument container has no frame: file /builds/slave/fx-team-osx64-d-00000000000000/build/layout/base/nsDocumentViewer.cpp, line 2515 17:32:07 INFO - 28445 INFO ++DOMWINDOW == 30 (0x10f3c2c00) [pid = 1294] [serial = 6871] [outer = 0x1152b4800] 17:32:08 INFO - 28446 INFO --DOCSHELL 0x11347a800 == 8 [pid = 1294] [id = 14] 17:32:08 INFO - 28447 INFO --DOCSHELL 0x100572000 == 7 [pid = 1294] [id = 3034] 17:32:08 INFO - 28448 INFO --DOCSHELL 0x122c0c000 == 6 [pid = 1294] [id = 3035] 17:32:09 INFO - 28449 INFO --DOMWINDOW == 29 (0x11aca0400) [pid = 1294] [serial = 6862] [outer = 0x10f844800] [url = about:blank] 17:32:09 INFO - 28450 INFO --DOMWINDOW == 28 (0x10f3c2800) [pid = 1294] [serial = 31] [outer = 0x11f1a2400] [url = data:application/vnd.mozilla.xul+xml;charset=utf-8,<window%20id='win'/>] 17:32:09 INFO - 28451 INFO --DOMWINDOW == 27 (0x10f3d1400) [pid = 1294] [serial = 6868] [outer = 0x1152b4400] [url = about:blank] 17:32:09 INFO - 28452 INFO --DOMWINDOW == 26 (0x11593d800) [pid = 1294] [serial = 9] [outer = 0x1152b4400] [url = about:blank] 17:32:09 INFO - 28453 INFO --DOMWINDOW == 25 (0x11593e000) [pid = 1294] [serial = 10] [outer = 0x1152b4800] [url = about:blank] 17:32:09 INFO - 28454 INFO --DOMWINDOW == 24 (0x11f1a2400) [pid = 1294] [serial = 28] [outer = 0x0] [url = data:application/vnd.mozilla.xul+xml;charset=utf-8,<window%20id='win'/>] 17:32:09 INFO - 28455 INFO --DOMWINDOW == 23 (0x114e02c00) [pid = 1294] [serial = 6869] [outer = 0x1152b4800] [url = about:blank] 17:32:09 INFO - 28456 INFO --DOMWINDOW == 22 (0x10f844800) [pid = 1294] [serial = 6861] [outer = 0x0] [url = about:blank] 17:32:09 INFO - 28457 INFO --DOMWINDOW == 21 (0x126141c00) [pid = 1294] [serial = 6865] [outer = 0x0] [url = http://test1.example.org/browser/toolkit/devtools/server/tests/browser/storage-updates.html] 17:32:09 INFO - 28458 INFO --DOMWINDOW == 20 (0x10f3c4000) [pid = 1294] [serial = 32] [outer = 0x0] [url = about:newtab] 17:32:09 INFO - 28459 INFO --DOMWINDOW == 19 (0x114e08000) [pid = 1294] [serial = 6863] [outer = 0x0] [url = http://test1.example.org/browser/toolkit/devtools/server/tests/browser/storage-updates.html] 17:32:10 INFO - 28460 INFO --DOMWINDOW == 18 (0x11ab79c00) [pid = 1294] [serial = 36] [outer = 0x0] [url = about:newtab] 17:32:26 INFO - 28461 INFO dumping last 2 message(s) 17:32:26 INFO - 28462 INFO if you need more context, please use SimpleTest.requestCompleteLog() in your test 17:32:26 INFO - 28463 INFO checking window state 17:32:26 INFO - 28464 INFO Console message: [JavaScript Error: "chrome://browser/content/browser.xul : Unable to run script because scripts are blocked internally."] 17:32:26 INFO - 28465 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_fetch-from-cache.js | leaked until shutdown [nsGlobalWindow #984 inner data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20<head>%20%20%20%20<style>%20%20%20%20%20%20html,%20body%20{%20height:%20100%;%20}%20%20%20%20%20%20body%20{%20margin:%200;%20overflow:%20hidden;%20}%20%20%20%20%20%20.CodeMirror%20{%20width:%20100%;%20height:%20100%%20!important;%20line-height:%201.25%20!important;}%20%20%20%20</style>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20hre data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20<head>%20%20%20%20<style>%20%20%20%20%20%20html,%20body%20{%20height:%20100%;%20}%20%20%20%20%20%20body%20{%20margin:%200;%20overflow:%20hidden;%20}%20%20%20%20%20%20.CodeMirror%20{%20width:%20100%;%20height:%20100%%20!important;%20line-height:%201.25%20!important;}%20%20%20%20</style>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/codemirror.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/dialog.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/mozilla.css'>%20%20</head>%20%20<body%20class='theme-body%20devtools-monospace'></body></html>] 17:32:26 INFO - TEST-INFO | expected PASS 17:32:26 INFO - 28466 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_fetch-from-cache.js | leaked until shutdown [nsGlobalWindow #983 outer data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20<head>%20%20%20%20<style>%20%20%20%20%20%20html,%20body%20{%20height:%20100%;%20}%20%20%20%20%20%20body%20{%20margin:%200;%20overflow:%20hidden;%20}%20%20%20%20%20%20.CodeMirror%20{%20width:%20100%;%20height:%20100%%20!important;%20line-height:%201.25%20!important;}%20%20%20%20</style>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/codemirror.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/dialog.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/mozilla.css'>%20%20</head>%20%20<body%20class='theme-body%20devtools-monospace'></body></html>] 17:32:26 INFO - TEST-INFO | expected PASS 17:32:26 INFO - 28467 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_fetch-from-cache.js | leaked until shutdown [nsGlobalWindow #975 inner chrome://browser/content/devtools/framework/toolbox.xul chrome://browser/content/devtools/framework/toolbox.xul] 17:32:26 INFO - TEST-INFO | expected PASS 17:32:26 INFO - 28468 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_fetch-from-cache.js | leaked until shutdown [nsGlobalWindow #973 outer chrome://browser/content/devtools/framework/toolbox.xul] }

Sami Jaktholm

Assignee

Comment 1

•

10 years ago

Attached patch styleeditor-test-toolbox-cleanup.patch (deleted) — Details — Splinter Review

It appears that occasionally toolbox doesn't have enough time to destroy itself on tab close before check for leaks is performed. Here's a patch that should fix this issue. Similar patch fixed similar issues in inspector too (bug 1037280). Try: https://tbpl.mozilla.org/?tree=Try&rev=dcc75a15cd71 https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dcc75a15cd71

Assignee: nobody → sjakthol

Status: NEW → ASSIGNED

Attachment #8475770 - Flags: review?(fayearthur)

Heather Arthur [:harth]

Comment 2

•

10 years ago

Comment on attachment 8475770 [details] [diff] [review] styleeditor-test-toolbox-cleanup.patch Review of attachment 8475770 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!

Attachment #8475770 - Flags: review?(fayearthur) → review+

Sami Jaktholm

Assignee

Updated

•

10 years ago

Keywords: checkin-needed

Ryan VanderMeulen [:RyanVM]

Comment 3

•

10 years ago

https://hg.mozilla.org/integration/fx-team/rev/7871ef26e0c8

Keywords: checkin-needed

Whiteboard: [fixed-in-fx-team]

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 4

•

10 years ago

https://hg.mozilla.org/mozilla-central/rev/7871ef26e0c8

Status: ASSIGNED → RESOLVED

Closed: 10 years ago

Resolution: --- → FIXED

Whiteboard: [fixed-in-fx-team]

Target Milestone: --- → Firefox 34

Ryan VanderMeulen [:RyanVM]

Comment 5

•

10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc9ca0a9f073 https://hg.mozilla.org/releases/mozilla-beta/rev/8f49d60bf5c9

status-firefox32: --- → fixed

status-firefox33: --- → fixed

status-firefox34: --- → fixed

status-firefox-esr24: --- → unaffected

status-firefox-esr31: --- → affected

Ryan VanderMeulen [:RyanVM]

Comment 6

•

10 years ago

https://hg.mozilla.org/releases/mozilla-esr31/rev/e53d607c91df

status-firefox-esr31: affected → fixed

Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)

Updated

•

10 years ago

Flags: qe-verify-

Comment hidden (Legacy TBPL/Treeherder Robot)

BMO Automation

Updated

•

6 years ago

Product: Firefox → DevTools

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Intermittent browser_styleeditor_fetch-from-cache.js | leaked 2 window(s) until shutdown (and many more)

Categories

(DevTools :: Style Editor, defect)

Tracking

(firefox32 fixed, firefox33 fixed, firefox34 fixed, firefox-esr24 unaffected, firefox-esr31 fixed)

People

(Reporter: emorley, Assigned: sjakthol)

References

Details

(Keywords: intermittent-failure)

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Updated

Comment 3

Comment 4

Comment 5

Comment 6

Updated

Comment 7

Comment 8

Comment 9

Updated

Attachment

General

Description

File Name

Content Type