Closed Bug 1058036 Opened 10 years ago Closed 10 years ago

Dependency on install manifest lost for preprocessed files

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I was working on some install manifest foo on a plane and found a bug in dependencies. Essentially, the install manifest wasn't being recorded as a dependency. So if the set of defines changed (stored in the install manifest), we didn't redo preprocessing. I'm sure this bug is responsible for at least one clobber in the past few months. I'm too lazy to dig through all the open bugs. Patch forthcoming.
The install manifest processor starts with an empty InstallManifest and uses |= to "concatenate" instances. It became pretty obvious when developing some patches that add more preprocessed files to install manifests that the source install manifest dependency was getting lost during the |= operation. This patch fixes it. The solution is not ideal performance wise. But slightly worse performance (only after config.status, however) is better than clobbers. A test has been added to ensure this doesn't regress.
Attachment #8478270 - Flags: review?(mh+mozilla)
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #8478270 - Flags: review?(mh+mozilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: