Closed
Bug 1058794
Opened 10 years ago
Closed 10 years ago
[CSS/SVG Filters][Refactoring] Change some functions in nsFilterInstance.cpp to return a value instead of nsresult
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: mvujovic, Assigned: mvujovic)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mstange
:
review+
mvujovic
:
checkin+
|
Details | Diff | Splinter Review |
The following functions always return NS_OK directly and an nsRect/nsRegion by reference:
nsFilterInstance::ComputePostFilterDirtyRegion
nsFilterInstance::ComputePostFilterExtents
nsFilterInstance::ComputeSourceNeededRect
We might as well have them return their nsRect/nsRegion directly.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8483629 -
Flags: review?(mstange)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8483629 [details] [diff] [review]
Patch
Nice!
Attachment #8483629 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8483629 [details] [diff] [review]
Patch
https://hg.mozilla.org/integration/mozilla-inbound/rev/b69530f4eb03
https://tbpl.mozilla.org/?tree=Try&rev=b00d1e2c72db
Attachment #8483629 -
Flags: checkin+
Assignee: nobody → mvujovic
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•