Closed
Bug 1058801
Opened 10 years ago
Closed 10 years ago
[CSS/SVG Filters][Refactoring] Make mFilter a const reference in nsSVGFilterInstance, like in nsCSSFilterInstance
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: mvujovic, Assigned: mvujovic)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mvujovic
:
checkin+
|
Details | Diff | Splinter Review |
And we should add a comment like the one in nsCSSFilterInstance:
* @param aFilter The CSS filter from the style system. This class stores
* aFilter by reference, so callers should avoid modifying or deleting
* aFilter during the lifetime of nsCSSFilterInstance.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8483631 -
Flags: review?(mstange)
|
||
Updated•10 years ago
|
Attachment #8483631 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Rebased patch for landing.
https://hg.mozilla.org/integration/mozilla-inbound/rev/647ead2013e3
https://tbpl.mozilla.org/?tree=Try&rev=b00d1e2c72db
Attachment #8483631 -
Attachment is obsolete: true
Attachment #8484317 -
Flags: checkin+
Assignee: nobody → mvujovic
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•