Closed
Bug 1058921
Opened 10 years ago
Closed 10 years ago
Disable unsafe Window APIs in prerendering
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: rvid, Assigned: rvid)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review-
|
Details | Diff | Splinter Review |
close, focus, open, alert, confirm, prompt, print, showModalDialog, moveTo, moveBy, resizeTo, resizeBy, back, forward, home, maximize, minimize, restore, sizeToContent, fullscreen, find
|
Assignee | |
Updated•10 years ago
|
Blocks: prerendering
|
|
Assignee | |
Updated•10 years ago
|
Summary: Disable some Window APIs in prerendering → Disable unsafe Window APIs in prerendering
|
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → roshanvid
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8483800 -
Flags: review?(jst)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8483800 [details] [diff] [review]
1058921.patch
These changes all look good, but we should also flag innerWidth, innerHeight, outerWidth, outerHeight. Though for those we probably only want to flag the setters... do we have support for that already?
r- to deal with those additional properties.
Attachment #8483800 -
Flags: review?(jst) → review-
|
|
||
Comment 3•10 years ago
|
||
Oh, forgot to mention that those properties are disabled by default, but can be enabled per site, so we may want to do the checking in the implementation of those rather than using webidl annotations.
|
||
Comment 4•10 years ago
|
||
I filed bug 1117876 as a follow-up to this to blacklist those setters as well. We probably want to do that in the implementation which is why I'm breaking that up into its own bug.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7fdb9bfb672
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•