I get this build-warning-spew in clang in current mozilla-central: { 0:02.98 In file included from /scratch/work/builds/mozilla-central/mozilla-central.12-12-07.08-38/mozilla/gfx/tests/gtest/TestAsyncPanZoomController.cpp:6: 0:02.98 Warning: -Wsign-compare in /scratch/work/builds/mozilla-central/mozilla-central.12-12-07.08-38/obj/dist/include/gtest/gtest.h: comparison of integers of different signs: 'const int' and 'const unsigned int' 0:02.98 ../../../dist/include/gtest/gtest.h:1316:16: warning: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Wsign-compare] 0:02.98 if (expected == actual) { 0:02.98 ~~~~~~~~ ^ ~~~~~~ 0:02.98 ../../../dist/include/gtest/gtest.h:1352:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned int>' requested here 0:02.98 return CmpHelperEQ(expected_expression, actual_expression, expected, 0:02.98 ^ 0:02.98 /scratch/work/builds/mozilla-central/mozilla-central.12-12-07.08-38/mozilla/gfx/tests/gtest/TestAsyncPanZoomController.cpp:1484:5: note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<int, unsigned int>' requested here 0:02.98 EXPECT_EQ(1, aLayer->GetFrameMetricsCount()); 0:02.98 ^ 0:02.98 ../../../dist/include/gtest/gtest.h:1848:67: note: expanded from macro 'EXPECT_EQ' 0:02.98 EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \ 0:02.98 ^ 0:02.98 ../../../dist/include/gtest/gtest_pred_impl.h:162:23: note: expanded from macro 'EXPECT_PRED_FORMAT2' 0:02.98 GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_) 0:02.98 ^ 0:02.98 ../../../dist/include/gtest/gtest_pred_impl.h:147:17: note: expanded from macro 'GTEST_PRED_FORMAT2_' 0:02.98 GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2),\ 0:02.98 ^ 0:02.98 ../../../dist/include/gtest/gtest_pred_impl.h:77:52: note: expanded from macro 'GTEST_ASSERT_' 0:02.98 if (const ::testing::AssertionResult gtest_ar = (expression)) \ 0:02.98 ^ } This is from this line, added for bug 1058886: > EXPECT_EQ(1, aLayer->GetFrameMetricsCount()); http://hg.mozilla.org/mozilla-central/rev/07d1e106d250#l1.13 That needs to be "1u" to match the signedness of GetFrameMetricsCount. That change fixes the warning-spew for me.

(Note: if/when bug 1058886 is uplifted to Aurora, let's uplift this as well, since it's test-only, is a correctness fix, and makes builds quieter.)

Interestingly, the patch posted to bug 1058886 has the '1u', but the one that landed doesn't.

Comment on attachment 8485306 [details] [diff] [review] fix Review of attachment 8485306 [details] [diff] [review]: ----------------------------------------------------------------- Stealing review.

Thanks! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/4914c3127025

Thanks for fixing this! I remember adding the u because I ran into the error locally too but apparently I landed the older version of the patch rather than the new one. Whoops!