Closed Bug 1068659 Opened 10 years ago Closed 10 years ago

No data connectivity sign feels a bit too big compared to other radio tech

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.0 unaffected, b2g-v2.0M unaffected, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S5 (26sep)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.0M --- unaffected
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: gerard-majax, Assigned: apastor)

References

Details

(Whiteboard: [systemsfe])

Attachments

(4 files)

Displaying the 'o' indicator
(deleted), image/png
Details
Displaying H+
(deleted), image/png
Details
Displaying 4G
(deleted), image/png
Details
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24187
(deleted), text/x-github-pull-request
mikehenrty
: review+
epang
: ui-review+
fabrice
: approval-gaia-v2.1+
Details
When we have no radio tech being identified (type: null), we display a 'o' as a sign in the status bar. Comparing the size and/or position of this with other radio tech indicator (H+, 3G), I feel it's a bit too big and misplaced.
Flags: needinfo?(swilkes)
Flags: needinfo?(apastor)
Attached image Displaying the 'o' indicator (deleted) —
Attached image Displaying H+ (deleted) —
Attached image Displaying 4G (deleted) —
Thanks :gerard-majax. Asking :epang for visual feedback, but I think you are totally right
Flags: needinfo?(apastor) → needinfo?(epang)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S5 (26sep)
blocking-b2g: 2.2? → 2.2+
Assignee: nobody → apastor
Attachment #8491577 - Flags: ui-review?(epang)
Attachment #8491577 - Flags: review?(mhenretty)
Comment on attachment 8491577 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24187 Thanks for working on this Alberto! Looks good to me! R+
Attachment #8491577 - Flags: ui-review?(epang) → ui-review+
Flags: needinfo?(epang)
Clearing need info on Steph :)
Flags: needinfo?(swilkes)
Attachment #8491577 - Flags: review?(mhenretty) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
Blocks: 1056969
Alberto, since bug 1056969 is going to be uplifted, let's request this one too.
status-b2g-v2.0: --- → unaffected
status-b2g-v2.0M: --- → unaffected
status-b2g-v2.1: --- → affected
Flags: needinfo?(apastor)
[Blocking Requested - why for this release]: Regression from 1056969, which has been uplifted
blocking-b2g: 2.2+ → 2.1?
Flags: needinfo?(apastor)
Comment on attachment 8491577 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24187 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1056969 [User impact] if declined: No-data icon feels too big compared with the rest [Testing completed]: Manual testing [Risk to taking this patch] (and alternatives if risky): Low risk. CSS only [String changes made]: -
Attachment #8491577 - Flags: approval-gaia-v2.1?
Regression.
blocking-b2g: 2.1? → 2.1+
Attachment #8491577 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Fix verified on Flame 2.2 and Flame 2.1 nightly builds. Actual result: The o data connection type icon is show the same size as other data connection type icons. Flame 2.2 BuildID: 20141015040201 Gaia: 5f1f0960ae9d22acf2a324ad37a48174d6df87f6 Gecko: 62f0b771583c Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Platform Version: 36.0a1 Firmware Version: V180 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0 Flame 2.1 BuildID: 20141015001201 Gaia: 379ea4c9dd6d3f8ca2f79ce59c15f6afe6e557c3 Gecko: 4853208cb48a Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Platform Version: 34.0 Firmware Version: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.1: fixed → verified
status-b2g-v2.2: fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: