I think initializing the newtab preloader automatically, 5s after startup, was a bad idea. We should let it initialize lazily when the first new tab is opened.

Now I just need to find someone to review with Drew being out of office for a while... Hmm.

Comment on attachment 8496608 [details] [diff] [review] 0001-Bug-1073993-Let-the-BrowserNewTabPreloader-initializ.patch Oh, great! I forgot that Jared did a whole bunch of reviews a while ago :)

Comment on attachment 8496608 [details] [diff] [review] 0001-Bug-1073993-Let-the-BrowserNewTabPreloader-initializ.patch Review of attachment 8496608 [details] [diff] [review]: ----------------------------------------------------------------- Do you expect that this will help improve new-tab loading times because New Tabs may have been created before this was initialized? Or because a new tab was being preloaded while a separate new tab was being created (they were racing together)?

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3) > Do you expect that this will help improve new-tab loading times because New > Tabs may have been created before this was initialized? Or because a new tab > was being preloaded while a separate new tab was being created (they were > racing together)? I'm actually more on the side of simplifying things here and having a little less startup impact. The goal this week is to improve newtab performance by a lot until even a non-preloaded about:newtab should perform reasonably well.

Pushed a tiny follow-up to allow disabling the preloader again. Accidentally broke that with the previous cset. https://hg.mozilla.org/integration/fx-team/rev/f269e2295c37

https://hg.mozilla.org/mozilla-central/rev/135c9657eb38 https://hg.mozilla.org/mozilla-central/rev/f269e2295c37