This fixes a big performance problem on Intel & AMD

I would suggest we take chromium/2175

I think this push will work: https://tbpl.mozilla.org/?tree=Try&rev=964e1e06af14

This broke the "not CONFIG['MOZ_HAS_WINSDK_WITH_D3D']" case. It should either be removed or fixed. In the current state of affairs, it means it breaks seamonkey (again).

z:\mozilla-inbound\gfx\angle\src\common/NativeWindow.h(23) : error C2146: syntax error : missing ';' before identifier 'DXGISwapChain' z:\mozilla-inbound\gfx\angle\src\common/NativeWindow.h(23) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int z:\mozilla-inbound\gfx\angle\src\common/NativeWindow.h(23) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int z:\mozilla-inbound\gfx\angle\src\common/NativeWindow.h(24) : error C2146: syntax error : missing ';' before identifier 'DXGIFactory' z:\mozilla-inbound\gfx\angle\src\common/NativeWindow.h(24) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int z:\mozilla-inbound\gfx\angle\src\common/NativeWindow.h(24) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int z:\mozilla-inbound\gfx\angle\src\common/NativeWindow.h(40) : error C2061: syntax error : identifier 'ID3D11Device' z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(23) : error C2065: 'ID3D11Device' : undeclared identifier z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(23) : error C2065: 'device' : undeclared identifier z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(23) : error C2065: 'factory' : undeclared identifier z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(24) : error C2065: 'DXGI_FORMAT' : undeclared identifier z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(24) : error C2146: syntax error : missing ')' before identifier 'format' z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(24) : error C2761: 'HRESULT rx::NativeWindow::createSwapChain(void)' : member function redeclaration not allowed z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(25) : error C2059: syntax error : ')' z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(26) : error C2143: syntax error : missing ';' before '{' z:\mozilla-inbound\gfx\angle\src\libGLESv2\../common/win32/NativeWindow.cpp(26) : error C2447: '{' : missing function header (old-style formal list?) z:/mozilla-inbound/config/rules.mk:948: recipe for target 'Unified_cpp_angle_src_libGLESv20.obj' failed

This is with WinSDK 7.1. The failure goes away if I backout changeset 06823a8d8be6

I fixed my local SDK 7.1 build by wrapping parts of NativeWindow.h/cpp in #ifdef ANGLE_ENABLE_D3D11 in particular the two typesdefs and the declaration and definition of NativeWindow::createSwapChain.

I followed Neil's advice in comment 9 and now it builds. I can do this locally but I can't do that with the c-c and c-a Win32 builds/debugs. What is the right way of fixing this?

Can we do a patch based on the approach?

(In reply to Jeff Muizelaar [:jrmuizel] from comment #11) > Can we do a patch based on the approach? Sure.