Closed
Bug 1084509
Opened 10 years ago
Closed 10 years ago
passing --jsconsole option doesn't show the console
Categories
(DevTools :: Console, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: blassey, Assigned: jryans)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
on #devtools jryans said that he saw a stack when he tried, but I don't see that stack in my console output
Assignee | ||
Comment 1•10 years ago
|
||
I tried "mach run --jsconsole" and got:
onPacket threw an exception: Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'listTabs: TypeError: aWindow.gBrowser is undefined\nStack: BrowserTabList.prototype._getChildren@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:288:3\nBrowserTabList.prototype._getBrowsers@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:281:25\nBrowserTabList.prototype.getList@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:314:3\nRootActor.prototype.onListTabs@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/root.js:264:12\nDSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1407:15\nLocalDebuggerTransport.prototype.send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:545:11\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14\nLine: 288, column: 2"}
Stack: DebuggerClient.prototype.onPacket/<@resource://gre/modules/devtools/dbg-client.jsm:873:1
resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
then@resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
then@resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:869:1
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:545:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
Line: 873, column: 0
Component: Developer Tools → Developer Tools: Console
Summary: passing --jsconsole option doesn't show the jsconole → passing --jsconsole option doesn't show the console
Comment 2•10 years ago
|
||
STR
firefox.exe -jsconsole
Regression window(fx-team)
Good:
https://hg.mozilla.org/integration/fx-team/rev/54b2b11d1895
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141013225458
Bad:
https://hg.mozilla.org/integration/fx-team/rev/2be42fbc9d98
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141014011156
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=54b2b11d1895&tochange=2be42fbc9d98
Suspect: Bug 975084
Assignee | ||
Comment 3•10 years ago
|
||
That's not too surprising to be honest... I'll take a look next week.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8508218 -
Flags: review?(poirot.alex)
Comment 5•10 years ago
|
||
Comment on attachment 8508218 [details] [diff] [review]
gBrowser might not be available on all windows
Review of attachment 8508218 [details] [diff] [review]:
-----------------------------------------------------------------
No tests being broken ?! :/
Attachment #8508218 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] from comment #5)
> Comment on attachment 8508218 [details] [diff] [review]
> gBrowser might not be available on all windows
>
> Review of attachment 8508218 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> No tests being broken ?! :/
Yeah... :/ I believe it's because in this case we list tabs very early during startup, but I don't know for certain. Anyway, real usage of the tab list does work other than this case.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•