Closed Bug 108745 Opened 23 years ago Closed 21 years ago

js errors in mailNavigatorOverlay.xul (popup has no properties)

Categories

(SeaMonkey :: UI Design, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.1alpha

People

(Reporter: bugzilla, Assigned: neil)

References

Details

Attachments

(3 files)

spun off from bug 86238. 0. make sure js strict errors pref is turned on [Debug panel]. 1. go to http://about: 2. open the js console. 3. view the source of http://about: results: get the following errors: Error: popup has no properties Source File: chrome://messenger/content/mailNavigatorOverlay.xul Line: 77 Error: popup has no properties Source File: chrome://editor/content/editorApplicationOverlay.js Line: 82 [above errors from the 2001.11.06.12-commercial verif build on linux.]
this will probably be fixed when I split navigatorOverlay.xul into 2 files (one for navigator only, one for viewsource/navigator shared stuff)
Depends on: 110506
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9
confirmed, this doesn't happen for my fix for 110506 (have not attached patch yet)
This is still the same in 2001=-12-06-03, with the navigator.js/browser.js split up But hey, a simple check one liner would fix this: if (popup!=null)
Removing " when viewing source of 'about:' " from summary. It happens on any html page (including empty ones). Win98, 2001122103.
Summary: js errors in mailNavigatorOverlay.xul & editorApplicationOverlay.js when viewing source of 'about:' → js errors in mailNavigatorOverlay.xul & editorApplicationOverlay.js
*** Bug 117825 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla0.9.9 → mozilla1.0
*** Bug 111462 has been marked as a duplicate of this bug. ***
*** Bug 124121 has been marked as a duplicate of this bug. ***
*** Bug 125874 has been marked as a duplicate of this bug. ***
nsbeta1- per ADT triage team
Keywords: nsbeta1nsbeta1-
*** Bug 128713 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla1.0 → mozilla1.1
Can we at least put try/catch around the offending code if we're not going to fix the real problem? People keep reporting this error output in unrelated bugs, thinking that it's related. It looks ridiculously unprofessional and makes it much harder to get useful data from bug reporters.
Attached patch patch (deleted) — Splinter Review
try/catch using popup to prevent error messages to the console.
Keywords: patch, review
The editor fix is already in another patch that will hopefully be checked in soon. I've reviewed the mailnews patch (r=brade) but you need module owner permission to check it in so I am not checking the checkbox since varada or ducarroz or someone else should review it before it gets checked in.
*** Bug 134269 has been marked as a duplicate of this bug. ***
changing summary to make the bug easier to find for that specific error ...
Summary: js errors in mailNavigatorOverlay.xul & editorApplicationOverlay.js → js errors in mailNavigatorOverlay.xul & editorApplicationOverlay.js (popup has no properties)
The editorApplicationOverlay JS error was fixed as part of another bug. Reducing summary
Summary: js errors in mailNavigatorOverlay.xul & editorApplicationOverlay.js (popup has no properties) → js errors in mailNavigatorOverlay.xul (popup has no properties)
Bug 133482 is a duplicate of this bug.
*** Bug 133482 has been marked as a duplicate of this bug. ***
Attached patch Proposed Patch (deleted) — Splinter Review
This patch also cleans up the lame hack by removing the event listener.
Can someone take a look at Neil's patch?
Is this still an issue? Is the patch still current?
This happens At mozilla startup (Mac OS 9.1 Build 2002100911) - Set Moz to open Mail at startup. Quit - Launch. Wait the mail window - Open Javascript console. The message is here
I am still encountering this error with the stable release of 1.01 on Mac OS 10.2. I think it may be interfering with something else I am trying to do. Does this patch work for 1.01 on OS 10.2?
this seems to still be an issue - OSX 10.2.5/moz 2003041008 I'm seeing this on every startup, although the error I'm seeming seems to have shifted line numbers and is now: Error: popup has no properties Source File: chrome://messenger/content/mailNavigatorOverlay.xul Line: 97
Still evident using Mac/1.7b.
Attachment #81859 - Flags: superreview?(bienvenu)
Attachment #81859 - Flags: review+
Attachment #81859 - Flags: superreview?(bienvenu) → superreview+
Assignee: bugs → neil.parkwaycc.co.uk
Status: ASSIGNED → NEW
Attached patch Possible cleanup (deleted) — Splinter Review
It looks like rbs accidentally "fixed" the bug by uselessly including the contentAreaContextMenu into the view [partial] source xul. I've moved some stuff around in case anyone thinks it would be a good idea.
Comment on attachment 148725 [details] [diff] [review] Possible cleanup (unpatched we're still broken on mac os x)
Attachment #148725 - Flags: superreview?(bienvenu)
Attachment #148725 - Flags: review+
Attachment #148725 - Flags: superreview?(bienvenu) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 258392 has been marked as a duplicate of this bug. ***
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: