Closed Bug 1092966 Opened 10 years ago Closed 10 years ago

FM Radio app to follow text selection pattern

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.2+)

RESOLVED FIXED
2.2 S3 (9jan)
feature-b2g 2.2+

People

(Reporter: howie, Assigned: justindarc)

References

Details

Attachments

(2 files)

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text. * HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.
The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements. Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable. Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance: pref("selectioncaret.enabled", on); pref("selectioncaret.noneditable", on);
No impact on FMRadio either based on page 12 in spec: https://bug1092944.bugzilla.mozilla.org/attachment.cgi?id=8515798. Assigning to Justin to make sure we are not missing anything (make labels/titles non-selectable if they are not already). Thanks Hema
Assignee: nobody → jdarcangelo
This is a 2.2 feature.
feature-b2g: 2.2? → 2.2+
QA Whiteboard: [2.2-feature-qa+]
Target Milestone: --- → 2.2 S3 (9jan)
Status: NEW → ASSIGNED
Hi Justin, may we know if you are working on this one? thank you!
Flags: needinfo?(jdarcangelo)
ni Hema to make sure this land before Jan 12th.
Flags: needinfo?(hkoka)
(In reply to howie [:howie] from comment #4) > Hi Justin, may we know if you are working on this one? thank you! Yes, I'm working on this. I've been on holiday, but I'm resuming work today.
Flags: needinfo?(jdarcangelo)
Flags: needinfo?(hkoka)
Attached file pull-request (master) (deleted) —
Attachment #8545372 - Flags: review?(pzhang)
Comment on attachment 8545372 [details] pull-request (master) r=me, but i don't understand one of the comments in this patch, i.e. /* 1 */, please remove it if it's useless, thanks.
Attachment #8545372 - Flags: review?(pzhang) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: