Closed
Bug 1092969
Opened 10 years ago
Closed 10 years ago
Music app to follow text selection pattern
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(feature-b2g:2.2+, b2g-v2.2 fixed)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | fixed |
People
(Reporter: howie, Assigned: dkuo)
References
Details
Attachments
(2 files)
* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text.
* HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.
Reporter | ||
Comment 1•10 years ago
|
||
The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.
Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.
Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);
Updated•10 years ago
|
Assignee: nobody → dflanagan
Updated•10 years ago
|
QA Contact: echang
Updated•10 years ago
|
QA Whiteboard: [2.2-feature-qa+]
Comment 3•10 years ago
|
||
This bug has been sitting in my queue for a couple of weeks. I've just reviewed similar patches for Video and Gallery, which has made me realize that this patch won't be trivial like those were because the Music app has a search feature that needs to have text selection enabled.
Dominic: is this a bug you can take? If not, please ask Jim to take it.
Assignee: dflanagan → nobody
Flags: needinfo?(dkuo)
Assignee | ||
Comment 4•10 years ago
|
||
Sure, I can take this.
Assignee: nobody → dkuo
Flags: needinfo?(dkuo)
Comment 5•10 years ago
|
||
Once we know the possible effort, it would be great if you could update the target milestone. Thanks.
Flags: needinfo?(dkuo)
Assignee | ||
Comment 6•10 years ago
|
||
Jim, would you please review this patch? thanks.
Flags: needinfo?(dkuo)
Attachment #8540198 -
Flags: review?(squibblyflabbetydoo)
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Kevin Hu [:khu] from comment #5)
> Once we know the possible effort, it would be great if you could update the
> target milestone. Thanks.
After wrote the patch I realized this is a simple fix so should be okay to be landed by this week(If Jim get the review request), and I will just choose the closest milestone, thanks.
Target Milestone: --- → 2.2 S3 (9jan)
Comment 8•10 years ago
|
||
Comment on attachment 8540198 [details]
patch
I'm not quite sure how to test this out, but by inspection, this looks good. rs=me.
Attachment #8540198 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 9•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•