Bug 847435 adds an awesome new look to the tab history menu. There are a few improvements we should make for tablets: * Anchor the menu at the top, under the browser toolbar, instead of the bottom of the screen. * Restrict the width so the list doesn't fill the entire tablet screen.

Sounds good to me. Let's give this a try and get some screenshots?

History popup centered at the Top right corner of the screen for tablets APK files : https://www.dropbox.com/s/j7szwr29ait9fss/app-debug.apk?dl=0

Comment on attachment 8522340 [details] [diff] [review] 1093902 patch ver 1 Review of attachment 8522340 [details] [diff] [review]: ----------------------------------------------------------------- This is quite broken :) I'd still recommend getting an Android emulator up and running if at all possible since it will be slow to test and tweak your changes. Screenshot coming.

Padding is added as part of the view, so you'll need to do one of the following: * Use margins instead of padding on the same view * Add padding to the outer invisible view instead of the list Also, as shown here, 100 dip is far too small.

A new patch with margins corrected. The apk can be downloaded from https://www.dropbox.com/s/j7szwr29ait9fss/app-debug.apk?dl=0

Comment on attachment 8524178 [details] [diff] [review] 1093902 ver 1.1 Review of attachment 8524178 [details] [diff] [review]: ----------------------------------------------------------------- This is an improvement, but still needs some work. Here's screenshot of what it currently looks like for me on a Nexus 7 emulator: https://www.dropbox.com/s/x62ebiuagguezon/Screenshot%202014-11-17%2021.50.54.png?dl=0 A few suggestions: * The menu should be shifted down slightly so that the top is flush with the URL bar. * The menu should width should be at least doubled to 400dip, possibly more. * The border should also probably be shifted to the bottom since the menu is at the top. Also, there's a slight difference between the behavior of the tablet's back button and the toolbar back button: the tablet's back button always shows all history, whereas the toolbar back button shows only back history. Both menus are shown in the same place, though, which is confusing. What we may want to do is always show the same full back/forward history list, regardless of which button was clicked. This is what we do on desktop. Let's see if Anthony has any other suggestions.

(In reply to Brian Nicholson (:bnicholson) from comment #6) > A few suggestions: > * The menu should be shifted down slightly so that the top is flush with the > URL bar. Agree, good call Brian. Vivek, let's see if we can get them to not overlap. > * The menu should width should be at least doubled to 400dip, possibly more. It definitely could be wider. What's it currently set at? > * The border should also probably be shifted to the bottom since the menu is > at the top. Agree. But since it doesn't stretch the width of the screen, we might need it around 3 sides and not just 1. This is close Vivek! I think with these questions answered, the next round of changes should be easier.

(In reply to Anthony Lam (:antlam) from comment #7) > It definitely could be wider. What's it currently set at? 200dp in the last screenshot. Another option: we could probably set the width to wrap content with a max width so that the panel is only as wide as its contents. This would match desktop's behavior.

(In reply to Brian Nicholson (:bnicholson) from comment #8) > (In reply to Anthony Lam (:antlam) from comment #7) > > It definitely could be wider. What's it currently set at? > > 200dp in the last screenshot. Another option: we could probably set the > width to wrap content with a max width so that the panel is only as wide as > its contents. This would match desktop's behavior. I've also suggested to Vivek that we could try having it the same size as the URL bar. Talked with him a bit yesterday so let's see what he comes back with :)

As per discussions over irc, * New tablet history popup changes * popup width aligned with url bar * popup background changed to menu_popup background APk files & Screenshots : https://www.dropbox.com/sh/foukh9y1gz9xq68/AACj4aw1rI3HVc7Fzg9xIKVKa?dl=0

Comment on attachment 8527084 [details] [diff] [review] Tablet History UI Review of attachment 8527084 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/resources/values-v11/dimens.xml @@ +12,5 @@ > http://androidxref.com/4.2.2_r1/xref/frameworks/base/core/res/res/values/themes.xml#1287 --> > <dimen name="menu_item_row_height">44dp</dimen> > + <dimen name="tab_history_margin_left">21dp</dimen> > + <dimen name="tab_history_margin_top">92dp</dimen> > + <dimen name="tab_history_margin_right">180dp</dimen> Really hate hardcoding these margin values -- I'm worried these won't hold up between different tablet sizes and configurations. I'll wait for antlam's feedback before testing and reviewing this more thoroughly.

Comment on attachment 8527084 [details] [diff] [review] Tablet History UI Review of attachment 8527084 [details] [diff] [review]: ----------------------------------------------------------------- + for the screen shots! this looks good Vivek! But, I have a question about the fading on the right edge there. I can see what's underneath the grey showing through. I don't know why this is happening, maybe Bnicholson can help here?

Hey Brian, could you take a look as to why this is happening? Otherwise, this visually looks fine to me :)

Hey Vivek, You mentioned on IRC that the toolbar disappears when the user scrolls. In this case, the only way to trigger this UI is through the hardware button, therefore it should show along the bottom. If triggered through the top, it should show under the toolbar. Unless there I'm mistaken somewhere, that should cover the cases. If there is somehow a way the user can trigger the top UI, we should also reappear the toolbar at the same time. :) Hope that answers your questions!

Spoke with Vivek on IRC, For hardware back on Tablets, lets do full width on vertical and horizontal orientation for now.

Comment on attachment 8527084 [details] [diff] [review] Tablet History UI It's not obvious what the problem is with the background image (menu_popup_bg.9.png looks fine to me), but Vivek said he'll be able to look at this again soon.

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.