Closed
Bug 1094072
Opened 10 years ago
Closed 10 years ago
[Text selection] Selection carets does not update its position after devices is changing to landscape mode
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
TYLin
:
review+
|
Details | Diff | Splinter Review |
2014-11-05-02-30-19.png
Steps to reproduce:
1. Open UI tests app
2. Choose API at the bottom
3. Choose Copy Paste
4. Long press to select a word
5. Rotate the device to landscape mode
Result:
The position of selection carets does not update. See the attached 2014-11-05-02-30-19.png
Expected:
The position of selection carets should be correct.
|
Assignee | |
Comment 1•10 years ago
|
||
Let SelectionCarets inherits from nsIReflowObserver so it could refresh
its position after reflow. This fixes the incorrect position of
selection carets after we rotate the device to change the screen from
portrait mode to landscape mode and vice versa.
Try result:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2f494ed38bbd
Attachment #8517274 -
Flags: review?(roc)
Attachment #8517274 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 2•10 years ago
|
||
Rebase and delete an superfluous blank line in the constructor.
Attachment #8517274 -
Attachment is obsolete: true
Attachment #8517914 -
Flags: review+
|
||
Comment 3•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
|
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•