Closed
Bug 1094607
Opened 10 years ago
Closed 10 years ago
[Text selection] Move scroll observer logic to SelectionCarets
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
With the SelectionCarets::Init() added in bug 1094072, we could move scroll observer add/remove logic in nsDocumentViewer back to SelectionCarets to make the code cleaner.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8517929 -
Flags: review?(roc)
Comment on attachment 8517929 [details] [diff] [review]
Move scroll observer logic to SelectionCarets. r=roc
Review of attachment 8517929 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8517929 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•