Closed Bug 1106124 Opened 10 years ago Closed 10 years ago

Profiler tab time section background color is overridden on hover

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 37

People

(Reporter: ntim, Assigned: bgrins)

References

Details

Attachments

(2 files)

debugger-placeholder-screenshot.png
(deleted), image/png
Details
profiler-tab-hover-background.patch
(deleted), patch
vporof
: review+
Details | Diff | Splinter Review
I suspect these are regressions of bug 1102369. Debugger : Text color of placeholders for empty tab panels are black in dark theme Performance : In the "top" tabs, when hovering the selected tab, the tab loses it's blue background
Also, the search input background is too light in dark theme. var(--theme-body-background) would be a perfect fit here.
(In reply to Tim Nguyen [:ntim] from comment #1) > Also, the search input background is too light in dark theme. > var(--theme-body-background) would be a perfect fit here. We should be clear which of these issues are regressions of Bug 1102369, and should be uplifted. In this case, was the search input background changed in 1102369 or is this just a suggested theme improvement?
The border-color of the search inputs also changed btw (in dark theme).
According to the patch, you only changed the border color of the inputs, which gave me the illusion that the background was changed as well.
(In reply to Tim Nguyen [:ntim] from comment #0) > I suspect these are regressions of bug 1102369. > > Debugger : > Text color of placeholders for empty tab panels are black in dark theme > I can't figure out exactly what this means - can you post a screenshot or explain further? > Performance : > In the "top" tabs, when hovering the selected tab, the tab loses it's blue > background Good catch, got a fix for this
Flags: needinfo?(ntim007)
Blocks: 1102369
No longer depends on: 1102369
Attached image debugger-placeholder-screenshot.png (deleted) —
Happens with all debugger panes. You can go to about:blank to test the issue.
Flags: needinfo?(ntim007)
Focusing this on the profiler issue, will file a new one for the debugger pane issue
Summary: Various devtools theme issues → Profiler tab time section background color is overridden on hover
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8540341 - Flags: review?(vporof)
(In reply to Brian Grinstead [:bgrins] from comment #8) > Focusing this on the profiler issue, will file a new one for the debugger > pane issue Filed Bug 1114749
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1114749
Attachment #8540341 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/e5f550fa112c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: