Can't localize some strings in location bar / internet search ("Search for" and "Search using"). http://lxr.mozilla.org/mozilla/source/xpfe/components/search/resources/internet.js#91 http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/urlbarBindings.xml#387 Mozilla/5.0 (Windows; U; Windows NT 5.0; pl-PL; rv:0.9.6+) Gecko/20011120

Hmmm... This bug still exists ;))) Hello!!! Only one change: http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/urlbarBindings.xml#386 instead of http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/urlbarBindings.xml#387

marking NEW

Adding patch. File search.properties should go to: /cvsroot/mozilla/xpfe/components/search/resources/locale/en-US/search.properties

*** This bug has been marked as a duplicate of 86248 ***

This is a partial dupe - what about strings in internet search?

Marek. You are right. There are two places. We may just use your patch. In considering localization, the order of the two strings may be different in locales. Should we change searchFor=Search %S for \"%S\" to searchfor=Search %1 for "%2"?

Yes, we do. For the localization purpose, we need to change them to %1, %2, cause in other language like Japanese, the strings could be translated as: "Use %S search %S", instead of "Search %S using %S" "For %S, search %S", instead of "Search %S for %S"

Ok, will change it (it will be like in http://bugzilla.mozilla.org/attachment.cgi?id=66513&action=view patch). Is adding new file ok or should I put string from my search.properties file to navigator.properties?

Reopen! Marek. do you mind taking over the owner ship?

Either search.properties or navigator.properties is fine with me.

If you want to make a new file, why not put the searchFor string into that new file as well? By the way, where does the UI show the string? searchTitle=Search %S using %S I see the page title like "Search result - xxxxxx", which also seems hardcoded somewhere.

> Reopen! Marek. do you mind taking over the owner ship? Hmmm... I'm only reporter ;))) But if I can... > If you want to make a new file, why not put the searchFor string into that new > file as well? This string is used in location bar so I think that it belongs to navigator.properties? > By the way, where does the UI show the string? > searchTitle=Search %S using %S Don't know where ;))) But it is used in sidebar search... I think... Anyway this string also should be changed - it is hardcoded

Yes, you can, since you create the patch. Do you know how to checin and the checkin procedure?

Well, to save the trouble for you. I will close this bug as a dup and checkin Ying'patch in 86248. Thanks. *** This bug has been marked as a duplicate of 86248 ***

>> By the way, where does the UI show the string? >> searchTitle=Search %S using %S >Don't know where ;))) But it is used in sidebar search... I think... Anyway >this string also should be changed - it is hardcoded For the hardcoded string in internet.js, we should consider it as a seperate bug. Please create a new bug for that, or reopen this but change the summary. Also, we don't know yet that hardcoded string shows where on the UI, and no way to test. For less risk, we are going to check in the patch in 86248, to ONLY fix the location problem.

Changed QA contact to ruixu@netscape.com.

Verified. Please file a new bug for the hardcoded string ("Search using") in internet.js if find it.